Re: [PATCH 3/4] leds-lp5523: change the return type of lp5523_set_mode()

On Tue, Aug 21, 2012 at 5:03 PM, Kim, Milo wrote: > The return value of this function is not handled any place, so > make it as void type. > > And three if-statements are replaced with switch-statements. > This one looks fine with me. I will merge it after you rework on first 2 patches Thanks,

[PATCH 3/4] leds-lp5523: change the return type of lp5523_set_mode()

The return value of this function is not handled any place, so make it as void type. And three if-statements are replaced with switch-statements. Signed-off-by: Milo(Woogyom) Kim --- drivers/leds/leds-lp5523.c | 24 +--- 1 files changed, 13 insertions(+), 11 deletions(-)

Re: [PATCH 3/4] leds-lp5523: change the return type of lp5523_set_mode()

On Tue, Aug 21, 2012 at 5:03 PM, Kim, Milo milo@ti.com wrote: The return value of this function is not handled any place, so make it as void type. And three if-statements are replaced with switch-statements. This one looks fine with me. I will merge it after you rework on first 2 patches

[PATCH 3/4] leds-lp5523: change the return type of lp5523_set_mode()

The return value of this function is not handled any place, so make it as void type. And three if-statements are replaced with switch-statements. Signed-off-by: Milo(Woogyom) Kim milo@ti.com --- drivers/leds/leds-lp5523.c | 24 +--- 1 files changed, 13 insertions(+),