Re: [PATCH 3/4] mmc: mmc: enable ios.enhanced_strobe before mmc_set_timing

2016-12-25 Thread Shawn Lin
On 2016/12/23 17:18, Ritesh Harjani wrote: Hi Shawn, Do you think, below change should be fine? yes. I am still checking on what we discussed on Patch2. why I am asking is because - for HS400 in SDHC-MSM, we do the DLL re-calibration as per the HW sequence. So it is done in both the cases,

Re: [PATCH 3/4] mmc: mmc: enable ios.enhanced_strobe before mmc_set_timing

2016-12-25 Thread Shawn Lin
On 2016/12/23 17:18, Ritesh Harjani wrote: Hi Shawn, Do you think, below change should be fine? yes. I am still checking on what we discussed on Patch2. why I am asking is because - for HS400 in SDHC-MSM, we do the DLL re-calibration as per the HW sequence. So it is done in both the cases,

Re: [PATCH 3/4] mmc: mmc: enable ios.enhanced_strobe before mmc_set_timing

2016-12-23 Thread Ritesh Harjani
Hi Shawn, Do you think, below change should be fine? I am still checking on what we discussed on Patch2. why I am asking is because - for HS400 in SDHC-MSM, we do the DLL re-calibration as per the HW sequence. So it is done in both the cases, for HS400 mode without and with enhanced strobe

Re: [PATCH 3/4] mmc: mmc: enable ios.enhanced_strobe before mmc_set_timing

2016-12-23 Thread Ritesh Harjani
Hi Shawn, Do you think, below change should be fine? I am still checking on what we discussed on Patch2. why I am asking is because - for HS400 in SDHC-MSM, we do the DLL re-calibration as per the HW sequence. So it is done in both the cases, for HS400 mode without and with enhanced strobe

[PATCH 3/4] mmc: mmc: enable ios.enhanced_strobe before mmc_set_timing

2016-12-19 Thread Ritesh Harjani
Some controllers may need to configure few registers based on enhanced strobe mode while configuring to HS400 timing, thus make ios.enhanced_strobe to true before mmc_set_timing in mmc_select_hs400es. Signed-off-by: Ritesh Harjani --- drivers/mmc/core/mmc.c | 8 +++-

[PATCH 3/4] mmc: mmc: enable ios.enhanced_strobe before mmc_set_timing

2016-12-19 Thread Ritesh Harjani
Some controllers may need to configure few registers based on enhanced strobe mode while configuring to HS400 timing, thus make ios.enhanced_strobe to true before mmc_set_timing in mmc_select_hs400es. Signed-off-by: Ritesh Harjani --- drivers/mmc/core/mmc.c | 8 +++- 1 file changed, 7