Re: [PATCH 3/4] nvme-pci: add device coredump support

2019-05-04 Thread Minwoo Im
On 5/4/19 11:38 PM, Minwoo Im wrote: On 5/4/19 11:26 PM, Akinobu Mita wrote: 2019年5月4日(土) 19:04 Minwoo Im : + { NVME_REG_INTMS,   "intms",    32 }, + { NVME_REG_INTMC,   "intmc",    32 }, + { NVME_REG_CC,  "cc",   32 }, + { NVME_REG_CSTS,   

Re: [PATCH 3/4] nvme-pci: add device coredump support

2019-05-04 Thread Minwoo Im
On 5/4/19 11:26 PM, Akinobu Mita wrote: 2019年5月4日(土) 19:04 Minwoo Im : Hi, Akinobu, Regardless to reply of the cover, few nits here. On 5/2/19 5:59 PM, Akinobu Mita wrote: + +static const struct nvme_reg nvme_regs[] = { + { NVME_REG_CAP, "cap", 64 }, + {

Re: [PATCH 3/4] nvme-pci: add device coredump support

2019-05-04 Thread Akinobu Mita
2019年5月4日(土) 19:04 Minwoo Im : > > Hi, Akinobu, > > Regardless to reply of the cover, few nits here. > > On 5/2/19 5:59 PM, Akinobu Mita wrote: > > + > > +static const struct nvme_reg nvme_regs[] = { > > + { NVME_REG_CAP, "cap", 64 }, > > + { NVME_REG_VS,

Re: [PATCH 3/4] nvme-pci: add device coredump support

2019-05-04 Thread Minwoo Im
Hi, Akinobu, Regardless to reply of the cover, few nits here. On 5/2/19 5:59 PM, Akinobu Mita wrote: + +static const struct nvme_reg nvme_regs[] = { + { NVME_REG_CAP, "cap",64 }, + { NVME_REG_VS, "version",32 }, Why don't we just go with "vs"

[PATCH 3/4] nvme-pci: add device coredump support

2019-05-02 Thread Akinobu Mita
This enables to capture snapshot of controller information via device coredump machanism. The nvme device coredump creates the following coredump files. - regs: NVMe controller registers, including each I/O queue doorbell registers, in nvme-show-regs style text format. - sq: I/O