Re: [PATCH 3/4] regulator: da9052: Use apply_[reg|bit] with regmap based voltage_sel operations

2013-10-02 Thread Mark Brown
On Wed, Oct 02, 2013 at 12:15:00PM +0200, Michael Grzeschik wrote: > we should not play to much with generous functions for this pmics. With this > patch we loose the fix_io code path from da9052_reg_update. > I suggest that Mark queue the revert of this patch. This seems far too obscure to be

Re: [PATCH 3/4] regulator: da9052: Use apply_[reg|bit] with regmap based voltage_sel operations

2013-10-02 Thread Michael Grzeschik
Hi Axel, Mark, we should not play to much with generous functions for this pmics. With this patch we loose the fix_io code path from da9052_reg_update. include/linux/mfd/da9052.h ... if (da9052->fix_io) { ret = da9052->fix_io(da9052, reg); if (ret < 0)

Re: [PATCH 3/4] regulator: da9052: Use apply_[reg|bit] with regmap based voltage_sel operations

2013-10-02 Thread Michael Grzeschik
Hi Axel, Mark, we should not play to much with generous functions for this pmics. With this patch we loose the fix_io code path from da9052_reg_update. include/linux/mfd/da9052.h ... if (da9052-fix_io) { ret = da9052-fix_io(da9052, reg); if (ret 0)

Re: [PATCH 3/4] regulator: da9052: Use apply_[reg|bit] with regmap based voltage_sel operations

2013-10-02 Thread Mark Brown
On Wed, Oct 02, 2013 at 12:15:00PM +0200, Michael Grzeschik wrote: we should not play to much with generous functions for this pmics. With this patch we loose the fix_io code path from da9052_reg_update. I suggest that Mark queue the revert of this patch. This seems far too obscure to be

[PATCH 3/4] regulator: da9052: Use apply_[reg|bit] with regmap based voltage_sel operations

2012-12-17 Thread Axel Lin
Signed-off-by: Axel Lin --- drivers/regulator/da9052-regulator.c | 41 +- 1 file changed, 6 insertions(+), 35 deletions(-) diff --git a/drivers/regulator/da9052-regulator.c b/drivers/regulator/da9052-regulator.c index d096309..c6d8651 100644 ---

[PATCH 3/4] regulator: da9052: Use apply_[reg|bit] with regmap based voltage_sel operations

2012-12-17 Thread Axel Lin
Signed-off-by: Axel Lin axel@ingics.com --- drivers/regulator/da9052-regulator.c | 41 +- 1 file changed, 6 insertions(+), 35 deletions(-) diff --git a/drivers/regulator/da9052-regulator.c b/drivers/regulator/da9052-regulator.c index d096309..c6d8651 100644