Re: [tpmdd-devel] [PATCH 3/4] tpm: Convert tpm_tis driver to use dev_pm_ops from legacy pm_ops

2013-07-10 Thread Shuah Khan
Hi Peter, On 07/10/2013 05:30 PM, Peter Hüwe wrote: >> >> tpm_tis_resume() is defined originally in CONFIG_PM_SLEEP scope. I can >> make the change to have tpm_tis_resume() not be in CONFIG_PM_SLEEP scope >> and remove this CONFIG_PM_SLEEP when defining .pm. >> That does make sense looking at tpm

Re: [tpmdd-devel] [PATCH 3/4] tpm: Convert tpm_tis driver to use dev_pm_ops from legacy pm_ops

2013-07-10 Thread Peter Hüwe
Hi Shuah, thanks for your reply. > >> +#ifdef CONFIG_PM_SLEEP > >> + .driver = { > >> + .pm = &tpm_tis_pm, > >> + }, > >> +#endif > >> > >> }; > > > > I don't think the #if CONFIG_PM_SLEEP is required here. In this case, the SIMPLE_DEV_PM_OPS macro handles the case internally - i.e

Re: [tpmdd-devel] [PATCH 3/4] tpm: Convert tpm_tis driver to use dev_pm_ops from legacy pm_ops

2013-07-10 Thread Shuah Khan
On 07/10/2013 04:43 PM, Peter Hüwe wrote: > Hi, > > thanks for your patch >> static struct pnp_device_id tpm_pnp_tbl[] = { >> {"PNP0C31", 0}, /* TPM */ >> {"ATM1200", 0}, /* Atmel */ >> @@ -835,9 +834,12 @@ static struct pnp_driver tis_pnp_driver = { >> .name = "tpm

Re: [tpmdd-devel] [PATCH 3/4] tpm: Convert tpm_tis driver to use dev_pm_ops from legacy pm_ops

2013-07-10 Thread Peter Hüwe
Hi, thanks for your patch > static struct pnp_device_id tpm_pnp_tbl[] = { > {"PNP0C31", 0}, /* TPM */ > {"ATM1200", 0}, /* Atmel */ > @@ -835,9 +834,12 @@ static struct pnp_driver tis_pnp_driver = { > .name = "tpm_tis", > .id_table = tpm_pnp_tbl, > .p

[PATCH 3/4] tpm: Convert tpm_tis driver to use dev_pm_ops from legacy pm_ops

2013-07-09 Thread Shuah Khan
Convert drivers/char/tpm/tpm_tis.c to use dev_pm_ops instead of legacy pm_ops. This patch depends on pnp driver bus ops change to invoke pnp_driver dev_pm_ops. Signed-off-by: Shuah Khan --- drivers/char/tpm/tpm_tis.c | 60 ++-- 1 file changed, 24 inserti