Re: [PATCH 3/4] tpm: in tpm2_del_space check if ops pointer is still valid

Hi, On 26.01.21 16:29, Jarkko Sakkinen wrote: > On Sun, 2021-01-24 at 17:47 +0100, Lino Sanfilippo wrote: >> Hi Jarkko, >> >> On 17.01.21 at 19:13, Jarkko Sakkinen wrote: >>> I have hard time to believe that any of these patches are based on >>> actual regressions. >>> >>> /Jarko >>> >> patch 1 is

Re: [PATCH 3/4] tpm: in tpm2_del_space check if ops pointer is still valid

On Sun, 2021-01-24 at 17:47 +0100, Lino Sanfilippo wrote: > > Hi Jarkko, > > On 17.01.21 at 19:13, Jarkko Sakkinen wrote: > > > > I have hard time to believe that any of these patches are based on > > actual regressions. > > > > /Jarko > > > > patch 1 is indeed wrong (I oversaw the action cal

Re: [PATCH 3/4] tpm: in tpm2_del_space check if ops pointer is still valid

Hi Jarkko, On 17.01.21 at 19:13, Jarkko Sakkinen wrote: > > I have hard time to believe that any of these patches are based on > actual regressions. > > /Jarko > patch 1 is indeed wrong (I oversaw the action call in case of error), so please ignore it. However patches 2 and 3 are based on bugs

Re: [PATCH 3/4] tpm: in tpm2_del_space check if ops pointer is still valid

On Sat, Jan 16, 2021 at 02:22:40AM +0100, Lino Sanfilippo wrote: > From: Lino Sanfilippo > > In tpm2_del_space() the sessions are flushed by means of the tpm_chip > operations. However the concerning operations pointer my already be NULL at > this time in case that the chip has been unregistered

[PATCH 3/4] tpm: in tpm2_del_space check if ops pointer is still valid

From: Lino Sanfilippo In tpm2_del_space() the sessions are flushed by means of the tpm_chip operations. However the concerning operations pointer my already be NULL at this time in case that the chip has been unregistered (see tpm_chip_unregister() which calls tpm_del_char_device() which sets chi