[for-next][PATCH 3/4] tracing/uprobes: Kill the bogus UPROBE_HANDLER_REMOVE code in uprobe_dispatcher()

2014-06-30 Thread Steven Rostedt
From: Oleg Nesterov I do not know why dd9fa555d7bb "tracing/uprobes: Move argument fetching to uprobe_dispatcher()" added the UPROBE_HANDLER_REMOVE, but it looks wrong. OK, perhaps it makes sense to avoid store_trace_args() if the tracee is nacked by uprobe_perf_filter(). But then we should

Re: [PATCH 3/4] tracing/uprobes: Kill the bogus UPROBE_HANDLER_REMOVE code in uprobe_dispatcher()

2014-06-30 Thread Srikar Dronamraju
* Oleg Nesterov [2014-06-27 19:01:43]: > I do not know why dd9fa555d7bb "tracing/uprobes: Move argument fetching > to uprobe_dispatcher()" added the UPROBE_HANDLER_REMOVE, but it looks > wrong. > > OK, perhaps it makes sense to avoid store_trace_args() if the tracee is > nacked by

Re: [PATCH 3/4] tracing/uprobes: Kill the bogus UPROBE_HANDLER_REMOVE code in uprobe_dispatcher()

2014-06-30 Thread Namhyung Kim
On Fri, 27 Jun 2014 19:01:43 +0200, Oleg Nesterov wrote: > I do not know why dd9fa555d7bb "tracing/uprobes: Move argument fetching > to uprobe_dispatcher()" added the UPROBE_HANDLER_REMOVE, but it looks > wrong. > > OK, perhaps it makes sense to avoid store_trace_args() if the tracee is > nacked

Re: [PATCH 3/4] tracing/uprobes: Kill the bogus UPROBE_HANDLER_REMOVE code in uprobe_dispatcher()

2014-06-30 Thread Namhyung Kim
On Fri, 27 Jun 2014 19:01:43 +0200, Oleg Nesterov wrote: I do not know why dd9fa555d7bb tracing/uprobes: Move argument fetching to uprobe_dispatcher() added the UPROBE_HANDLER_REMOVE, but it looks wrong. OK, perhaps it makes sense to avoid store_trace_args() if the tracee is nacked by

Re: [PATCH 3/4] tracing/uprobes: Kill the bogus UPROBE_HANDLER_REMOVE code in uprobe_dispatcher()

2014-06-30 Thread Srikar Dronamraju
* Oleg Nesterov o...@redhat.com [2014-06-27 19:01:43]: I do not know why dd9fa555d7bb tracing/uprobes: Move argument fetching to uprobe_dispatcher() added the UPROBE_HANDLER_REMOVE, but it looks wrong. OK, perhaps it makes sense to avoid store_trace_args() if the tracee is nacked by

[for-next][PATCH 3/4] tracing/uprobes: Kill the bogus UPROBE_HANDLER_REMOVE code in uprobe_dispatcher()

2014-06-30 Thread Steven Rostedt
From: Oleg Nesterov o...@redhat.com I do not know why dd9fa555d7bb tracing/uprobes: Move argument fetching to uprobe_dispatcher() added the UPROBE_HANDLER_REMOVE, but it looks wrong. OK, perhaps it makes sense to avoid store_trace_args() if the tracee is nacked by uprobe_perf_filter(). But then

[PATCH 3/4] tracing/uprobes: Kill the bogus UPROBE_HANDLER_REMOVE code in uprobe_dispatcher()

2014-06-27 Thread Oleg Nesterov
I do not know why dd9fa555d7bb "tracing/uprobes: Move argument fetching to uprobe_dispatcher()" added the UPROBE_HANDLER_REMOVE, but it looks wrong. OK, perhaps it makes sense to avoid store_trace_args() if the tracee is nacked by uprobe_perf_filter(). But then we should kill the same code in

[PATCH 3/4] tracing/uprobes: Kill the bogus UPROBE_HANDLER_REMOVE code in uprobe_dispatcher()

2014-06-27 Thread Oleg Nesterov
I do not know why dd9fa555d7bb tracing/uprobes: Move argument fetching to uprobe_dispatcher() added the UPROBE_HANDLER_REMOVE, but it looks wrong. OK, perhaps it makes sense to avoid store_trace_args() if the tracee is nacked by uprobe_perf_filter(). But then we should kill the same code in