Re: [PATCH 3/4] tracing: Add stack_tracer_disable/enable() functions

On Thu, 6 Apr 2017 15:08:21 -0700 "Paul E. McKenney" wrote: > On Thu, Apr 06, 2017 at 05:23:48PM -0400, Steven Rostedt wrote: > > On Thu, 6 Apr 2017 13:21:17 -0700 > > "Paul E. McKenney" wrote: > > > > > > My worry is that we add

Re: [PATCH 3/4] tracing: Add stack_tracer_disable/enable() functions

On Thu, 6 Apr 2017 15:08:21 -0700 "Paul E. McKenney" wrote: > On Thu, Apr 06, 2017 at 05:23:48PM -0400, Steven Rostedt wrote: > > On Thu, 6 Apr 2017 13:21:17 -0700 > > "Paul E. McKenney" wrote: > > > > > > My worry is that we add another caller that doesn't disable interrupts > > > > or

Re: [PATCH 3/4] tracing: Add stack_tracer_disable/enable() functions

On Thu, Apr 06, 2017 at 05:23:48PM -0400, Steven Rostedt wrote: > On Thu, 6 Apr 2017 13:21:17 -0700 > "Paul E. McKenney" wrote: > > > > My worry is that we add another caller that doesn't disable interrupts > > > or preemption. > > > > > > I could add a

Re: [PATCH 3/4] tracing: Add stack_tracer_disable/enable() functions

On Thu, Apr 06, 2017 at 05:23:48PM -0400, Steven Rostedt wrote: > On Thu, 6 Apr 2017 13:21:17 -0700 > "Paul E. McKenney" wrote: > > > > My worry is that we add another caller that doesn't disable interrupts > > > or preemption. > > > > > > I could add a __stack_trace_disable() that skips the

Re: [PATCH 3/4] tracing: Add stack_tracer_disable/enable() functions

On Thu, 6 Apr 2017 13:21:17 -0700 "Paul E. McKenney" wrote: > > My worry is that we add another caller that doesn't disable interrupts > > or preemption. > > > > I could add a __stack_trace_disable() that skips the disabling of > > preemption, as the "__" usually

Re: [PATCH 3/4] tracing: Add stack_tracer_disable/enable() functions

On Thu, 6 Apr 2017 13:21:17 -0700 "Paul E. McKenney" wrote: > > My worry is that we add another caller that doesn't disable interrupts > > or preemption. > > > > I could add a __stack_trace_disable() that skips the disabling of > > preemption, as the "__" usually denotes the call is "special".

Re: [PATCH 3/4] tracing: Add stack_tracer_disable/enable() functions

On Thu, Apr 06, 2017 at 02:48:03PM -0400, Steven Rostedt wrote: > On Thu, 6 Apr 2017 11:12:22 -0700 > "Paul E. McKenney" wrote: > > > On Thu, Apr 06, 2017 at 12:42:40PM -0400, Steven Rostedt wrote: > > > From: "Steven Rostedt (VMware)" > > > > >

Re: [PATCH 3/4] tracing: Add stack_tracer_disable/enable() functions

On Thu, Apr 06, 2017 at 02:48:03PM -0400, Steven Rostedt wrote: > On Thu, 6 Apr 2017 11:12:22 -0700 > "Paul E. McKenney" wrote: > > > On Thu, Apr 06, 2017 at 12:42:40PM -0400, Steven Rostedt wrote: > > > From: "Steven Rostedt (VMware)" > > > > > > There are certain parts of the kernel that can

Re: [PATCH 3/4] tracing: Add stack_tracer_disable/enable() functions

On Thu, 6 Apr 2017 11:12:22 -0700 "Paul E. McKenney" wrote: > On Thu, Apr 06, 2017 at 12:42:40PM -0400, Steven Rostedt wrote: > > From: "Steven Rostedt (VMware)" > > > > There are certain parts of the kernel that can not let stack tracing > >

Re: [PATCH 3/4] tracing: Add stack_tracer_disable/enable() functions

On Thu, 6 Apr 2017 11:12:22 -0700 "Paul E. McKenney" wrote: > On Thu, Apr 06, 2017 at 12:42:40PM -0400, Steven Rostedt wrote: > > From: "Steven Rostedt (VMware)" > > > > There are certain parts of the kernel that can not let stack tracing > > proceed (namely in RCU), because the stack tracer

Re: [PATCH 3/4] tracing: Add stack_tracer_disable/enable() functions

On Thu, Apr 06, 2017 at 12:42:40PM -0400, Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > There are certain parts of the kernel that can not let stack tracing > proceed (namely in RCU), because the stack tracer uses RCU, and parts of RCU > internals can not

Re: [PATCH 3/4] tracing: Add stack_tracer_disable/enable() functions

On Thu, Apr 06, 2017 at 12:42:40PM -0400, Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > There are certain parts of the kernel that can not let stack tracing > proceed (namely in RCU), because the stack tracer uses RCU, and parts of RCU > internals can not handle having RCU read

[PATCH 3/4] tracing: Add stack_tracer_disable/enable() functions

From: "Steven Rostedt (VMware)" There are certain parts of the kernel that can not let stack tracing proceed (namely in RCU), because the stack tracer uses RCU, and parts of RCU internals can not handle having RCU read side locks taken. Add stack_tracer_disable() and

[PATCH 3/4] tracing: Add stack_tracer_disable/enable() functions

From: "Steven Rostedt (VMware)" There are certain parts of the kernel that can not let stack tracing proceed (namely in RCU), because the stack tracer uses RCU, and parts of RCU internals can not handle having RCU read side locks taken. Add stack_tracer_disable() and stack_tracer_enable()