Re: [PATCH 3/4] uprobes: rename vma_address() and make it return "unsigned long"

2012-07-27 Thread Srikar Dronamraju
* Oleg Nesterov [2012-07-26 12:28:12]: > On 07/26, Srikar Dronamraju wrote: > > > > * Oleg Nesterov [2012-07-12 19:10:22]: > > > > > 1. vma_address() returns loff_t, this looks confusing and this is > > >unnecessary after the previous change. Make it return "ulong", > > >all callers

Re: [PATCH 3/4] uprobes: rename vma_address() and make it return unsigned long

2012-07-27 Thread Srikar Dronamraju
* Oleg Nesterov o...@redhat.com [2012-07-26 12:28:12]: On 07/26, Srikar Dronamraju wrote: * Oleg Nesterov o...@redhat.com [2012-07-12 19:10:22]: 1. vma_address() returns loff_t, this looks confusing and this is unnecessary after the previous change. Make it return ulong, all

Re: [PATCH 3/4] uprobes: rename vma_address() and make it return "unsigned long"

2012-07-26 Thread Oleg Nesterov
On 07/26, Srikar Dronamraju wrote: > > * Oleg Nesterov [2012-07-12 19:10:22]: > > > 1. vma_address() returns loff_t, this looks confusing and this is > >unnecessary after the previous change. Make it return "ulong", > >all callers truncate the result anyway. > > > > 2. Its name conflicts

Re: [PATCH 3/4] uprobes: rename vma_address() and make it return unsigned long

2012-07-26 Thread Oleg Nesterov
On 07/26, Srikar Dronamraju wrote: * Oleg Nesterov o...@redhat.com [2012-07-12 19:10:22]: 1. vma_address() returns loff_t, this looks confusing and this is unnecessary after the previous change. Make it return ulong, all callers truncate the result anyway. 2. Its name conflicts

Re: [PATCH 3/4] uprobes: rename vma_address() and make it return "unsigned long"

2012-07-25 Thread Srikar Dronamraju
* Oleg Nesterov [2012-07-12 19:10:22]: > 1. vma_address() returns loff_t, this looks confusing and this is >unnecessary after the previous change. Make it return "ulong", >all callers truncate the result anyway. > > 2. Its name conflicts with mm/rmap.c:vma_address(), rename it to >

Re: [PATCH 3/4] uprobes: rename vma_address() and make it return unsigned long

2012-07-25 Thread Srikar Dronamraju
* Oleg Nesterov o...@redhat.com [2012-07-12 19:10:22]: 1. vma_address() returns loff_t, this looks confusing and this is unnecessary after the previous change. Make it return ulong, all callers truncate the result anyway. 2. Its name conflicts with mm/rmap.c:vma_address(), rename it

[PATCH 3/4] uprobes: rename vma_address() and make it return "unsigned long"

2012-07-12 Thread Oleg Nesterov
1. vma_address() returns loff_t, this looks confusing and this is unnecessary after the previous change. Make it return "ulong", all callers truncate the result anyway. 2. Its name conflicts with mm/rmap.c:vma_address(), rename it to offset_to_vaddr(), this matches vaddr_to_offset().

[PATCH 3/4] uprobes: rename vma_address() and make it return unsigned long

2012-07-12 Thread Oleg Nesterov
1. vma_address() returns loff_t, this looks confusing and this is unnecessary after the previous change. Make it return ulong, all callers truncate the result anyway. 2. Its name conflicts with mm/rmap.c:vma_address(), rename it to offset_to_vaddr(), this matches vaddr_to_offset().