* Oleg Nesterov [2012-07-26 12:28:12]:
> On 07/26, Srikar Dronamraju wrote:
> >
> > * Oleg Nesterov [2012-07-12 19:10:22]:
> >
> > > 1. vma_address() returns loff_t, this looks confusing and this is
> > >unnecessary after the previous change. Make it return "ulong",
> > >all callers
* Oleg Nesterov o...@redhat.com [2012-07-26 12:28:12]:
On 07/26, Srikar Dronamraju wrote:
* Oleg Nesterov o...@redhat.com [2012-07-12 19:10:22]:
1. vma_address() returns loff_t, this looks confusing and this is
unnecessary after the previous change. Make it return ulong,
all
On 07/26, Srikar Dronamraju wrote:
>
> * Oleg Nesterov [2012-07-12 19:10:22]:
>
> > 1. vma_address() returns loff_t, this looks confusing and this is
> >unnecessary after the previous change. Make it return "ulong",
> >all callers truncate the result anyway.
> >
> > 2. Its name conflicts
On 07/26, Srikar Dronamraju wrote:
* Oleg Nesterov o...@redhat.com [2012-07-12 19:10:22]:
1. vma_address() returns loff_t, this looks confusing and this is
unnecessary after the previous change. Make it return ulong,
all callers truncate the result anyway.
2. Its name conflicts
* Oleg Nesterov [2012-07-12 19:10:22]:
> 1. vma_address() returns loff_t, this looks confusing and this is
>unnecessary after the previous change. Make it return "ulong",
>all callers truncate the result anyway.
>
> 2. Its name conflicts with mm/rmap.c:vma_address(), rename it to
>
* Oleg Nesterov o...@redhat.com [2012-07-12 19:10:22]:
1. vma_address() returns loff_t, this looks confusing and this is
unnecessary after the previous change. Make it return ulong,
all callers truncate the result anyway.
2. Its name conflicts with mm/rmap.c:vma_address(), rename it
1. vma_address() returns loff_t, this looks confusing and this is
unnecessary after the previous change. Make it return "ulong",
all callers truncate the result anyway.
2. Its name conflicts with mm/rmap.c:vma_address(), rename it to
offset_to_vaddr(), this matches vaddr_to_offset().
1. vma_address() returns loff_t, this looks confusing and this is
unnecessary after the previous change. Make it return ulong,
all callers truncate the result anyway.
2. Its name conflicts with mm/rmap.c:vma_address(), rename it to
offset_to_vaddr(), this matches vaddr_to_offset().
8 matches
Mail list logo