Re: [PATCH 3/4] watchdog: move watchdog sysctl to watchdog.c

2020-05-15 Thread Xiaoming Ni
On 2020/5/15 16:09, Kees Cook wrote: On Fri, May 15, 2020 at 12:33:43PM +0800, Xiaoming Ni wrote: +static int sixty = 60; This should be const. (Which will require a cast during extra2 assignment.) Sorry, I forgot to append const. Thanks for your guidance. Thanks Xiaoming Ni

Re: [PATCH 3/4] watchdog: move watchdog sysctl to watchdog.c

2020-05-15 Thread Kees Cook
On Fri, May 15, 2020 at 12:33:43PM +0800, Xiaoming Ni wrote: > +static int sixty = 60; This should be const. (Which will require a cast during extra2 assignment.) -- Kees Cook

[PATCH 3/4] watchdog: move watchdog sysctl to watchdog.c

2020-05-14 Thread Xiaoming Ni
Move watchdog sysctl interface to watchdog.c. Use register_sysctl() to register the sysctl interface to avoid merge conflicts when different features modify sysctl.c at the same time. Signed-off-by: Xiaoming Ni --- kernel/sysctl.c | 96 kernel/watc