Re: [PATCH 3/4 v2] mm: fix return value in __alloc_contig_migrate_range()

2012-07-17 Thread JoonSoo Kim
2012/7/17 Michal Nazarewicz : > On Tue, 17 Jul 2012 14:33:34 +0200, Joonsoo Kim wrote: >> >> migrate_pages() would return positive value in some failure case, >> so 'ret > 0 ? 0 : ret' may be wrong. >> This fix it and remove one dead statement. > > > How about the following message: > >

Re: [PATCH 3/4 v2] mm: fix return value in __alloc_contig_migrate_range()

2012-07-17 Thread Michal Nazarewicz
On Tue, 17 Jul 2012 14:33:34 +0200, Joonsoo Kim wrote: migrate_pages() would return positive value in some failure case, so 'ret > 0 ? 0 : ret' may be wrong. This fix it and remove one dead statement. How about the following message: --- >8

[PATCH 3/4 v2] mm: fix return value in __alloc_contig_migrate_range()

2012-07-17 Thread Joonsoo Kim
migrate_pages() would return positive value in some failure case, so 'ret > 0 ? 0 : ret' may be wrong. This fix it and remove one dead statement. Signed-off-by: Joonsoo Kim Cc: Michal Nazarewicz Cc: Marek Szyprowski Cc: Minchan Kim Cc: Christoph Lameter Acked-by: Christoph Lameter diff

[PATCH 3/4 v2] mm: fix return value in __alloc_contig_migrate_range()

2012-07-17 Thread Joonsoo Kim
migrate_pages() would return positive value in some failure case, so 'ret 0 ? 0 : ret' may be wrong. This fix it and remove one dead statement. Signed-off-by: Joonsoo Kim js1...@gmail.com Cc: Michal Nazarewicz min...@mina86.com Cc: Marek Szyprowski m.szyprow...@samsung.com Cc: Minchan Kim

Re: [PATCH 3/4 v2] mm: fix return value in __alloc_contig_migrate_range()

2012-07-17 Thread Michal Nazarewicz
On Tue, 17 Jul 2012 14:33:34 +0200, Joonsoo Kim js1...@gmail.com wrote: migrate_pages() would return positive value in some failure case, so 'ret 0 ? 0 : ret' may be wrong. This fix it and remove one dead statement. How about the following message: --- 8

Re: [PATCH 3/4 v2] mm: fix return value in __alloc_contig_migrate_range()

2012-07-17 Thread JoonSoo Kim
2012/7/17 Michal Nazarewicz min...@mina86.com: On Tue, 17 Jul 2012 14:33:34 +0200, Joonsoo Kim js1...@gmail.com wrote: migrate_pages() would return positive value in some failure case, so 'ret 0 ? 0 : ret' may be wrong. This fix it and remove one dead statement. How about the following