[PATCH 3/5] AF_RXRPC: Make it possible to merely try to cancel timers and delayed work [try #3]

2007-03-20 Thread David Howells
Export try_to_del_timer_sync() for use by the RxRPC module. Add a try_to_cancel_delayed_work() so that it is possible to merely attempt to cancel a delayed work timer. Signed-Off-By: David Howells <[EMAIL PROTECTED]> --- include/linux/workqueue.h | 21 + kernel/timer.c

[PATCH 3/5] AF_RXRPC: Make it possible to merely try to cancel timers and delayed work [try #3]

2007-03-20 Thread David Howells
Export try_to_del_timer_sync() for use by the RxRPC module. Add a try_to_cancel_delayed_work() so that it is possible to merely attempt to cancel a delayed work timer. Signed-Off-By: David Howells [EMAIL PROTECTED] --- include/linux/workqueue.h | 21 + kernel/timer.c

Re: [PATCH 3/5] AF_RXRPC: Make it possible to merely try to cancel timers and delayed work [try #2]

2007-03-16 Thread David Howells
Alan Cox <[EMAIL PROTECTED]> wrote: > > +static inline int try_to_cancel_delayed_work(struct delayed_work *work) > > +{ > > + int ret; > > This expands to a fair bit of code and IMHO isn't an inline candidate. Then why is cancel_delayed_work() inline? It's very similar in terms of expansion.

Re: [PATCH 3/5] AF_RXRPC: Make it possible to merely try to cancel timers and delayed work [try #2]

2007-03-16 Thread Alan Cox
> +/** > + * try_to_cancel_delayed_work - Try to kill pending scheduled, delayed work > + * @work: the work to cancel > + * > + * Try to kill off a pending schedule_delayed_work(). > + * - The timer may still be running afterwards, and if so, the work may still > + * be pending > + * - Returns

[PATCH 3/5] AF_RXRPC: Make it possible to merely try to cancel timers and delayed work [try #2]

2007-03-16 Thread David Howells
Export try_to_del_timer_sync() for use by the RxRPC module. Add a try_to_cancel_delayed_work() so that it is possible to merely attempt to cancel a delayed work timer. Signed-Off-By: David Howells <[EMAIL PROTECTED]> --- include/linux/workqueue.h | 21 + kernel/timer.c

[PATCH 3/5] AF_RXRPC: Make it possible to merely try to cancel timers and delayed work [try #2]

2007-03-16 Thread David Howells
Export try_to_del_timer_sync() for use by the RxRPC module. Add a try_to_cancel_delayed_work() so that it is possible to merely attempt to cancel a delayed work timer. Signed-Off-By: David Howells [EMAIL PROTECTED] --- include/linux/workqueue.h | 21 + kernel/timer.c

Re: [PATCH 3/5] AF_RXRPC: Make it possible to merely try to cancel timers and delayed work [try #2]

2007-03-16 Thread Alan Cox
+/** + * try_to_cancel_delayed_work - Try to kill pending scheduled, delayed work + * @work: the work to cancel + * + * Try to kill off a pending schedule_delayed_work(). + * - The timer may still be running afterwards, and if so, the work may still + * be pending + * - Returns -1 if

Re: [PATCH 3/5] AF_RXRPC: Make it possible to merely try to cancel timers and delayed work [try #2]

2007-03-16 Thread David Howells
Alan Cox [EMAIL PROTECTED] wrote: +static inline int try_to_cancel_delayed_work(struct delayed_work *work) +{ + int ret; This expands to a fair bit of code and IMHO isn't an inline candidate. Then why is cancel_delayed_work() inline? It's very similar in terms of expansion. And it's

[PATCH 3/5] AF_RXRPC: Make it possible to merely try to cancel timers and delayed work

2007-03-08 Thread David Howells
Export try_to_del_timer_sync() for use by the RxRPC module. Add a try_to_cancel_delayed_work() so that it is possible to merely attempt to cancel a delayed work timer. Signed-Off-By: David Howells <[EMAIL PROTECTED]> --- include/linux/workqueue.h | 21 + kernel/timer.c

[PATCH 3/5] AF_RXRPC: Make it possible to merely try to cancel timers and delayed work

2007-03-08 Thread David Howells
Export try_to_del_timer_sync() for use by the RxRPC module. Add a try_to_cancel_delayed_work() so that it is possible to merely attempt to cancel a delayed work timer. Signed-Off-By: David Howells [EMAIL PROTECTED] --- include/linux/workqueue.h | 21 + kernel/timer.c