Re: [PATCH 3/5] ASoC: dwc: Iterate over all channels

2014-12-04 Thread Andrew Jackson
On 12/04/14 06:55, rajeev kumar wrote: > On Wed, Dec 3, 2014 at 10:59 PM, Mark Brown wrote: >> On Wed, Dec 03, 2014 at 04:39:01PM +, Andrew Jackson wrote: >> >>> + /* Iterate over set of channels - independently controlled. >>> + */ >>> + do { >>> + if

Re: [PATCH 3/5] ASoC: dwc: Iterate over all channels

2014-12-04 Thread Andrew Jackson
On 12/03/14 17:29, Mark Brown wrote: > On Wed, Dec 03, 2014 at 04:39:01PM +, Andrew Jackson wrote: > >> +/* Iterate over set of channels - independently controlled. >> + */ >> +do { >> +if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) { >> +

Re: [PATCH 3/5] ASoC: dwc: Iterate over all channels

2014-12-04 Thread Andrew Jackson
On 12/03/14 17:29, Mark Brown wrote: On Wed, Dec 03, 2014 at 04:39:01PM +, Andrew Jackson wrote: +/* Iterate over set of channels - independently controlled. + */ +do { +if (substream-stream == SNDRV_PCM_STREAM_PLAYBACK) { +

Re: [PATCH 3/5] ASoC: dwc: Iterate over all channels

2014-12-04 Thread Andrew Jackson
On 12/04/14 06:55, rajeev kumar wrote: On Wed, Dec 3, 2014 at 10:59 PM, Mark Brown broo...@kernel.org wrote: On Wed, Dec 03, 2014 at 04:39:01PM +, Andrew Jackson wrote: + /* Iterate over set of channels - independently controlled. + */ + do { + if

Re: [PATCH 3/5] ASoC: dwc: Iterate over all channels

2014-12-03 Thread rajeev kumar
On Wed, Dec 3, 2014 at 10:59 PM, Mark Brown wrote: > On Wed, Dec 03, 2014 at 04:39:01PM +, Andrew Jackson wrote: > >> + /* Iterate over set of channels - independently controlled. >> + */ >> + do { >> + if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) { >> +

Re: [PATCH 3/5] ASoC: dwc: Iterate over all channels

2014-12-03 Thread Mark Brown
On Wed, Dec 03, 2014 at 04:39:01PM +, Andrew Jackson wrote: > + /* Iterate over set of channels - independently controlled. > + */ > + do { > + if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) { > + i2s_write_reg(dev->i2s_base, TCR(ch_reg), > +

[PATCH 3/5] ASoC: dwc: Iterate over all channels

2014-12-03 Thread Andrew Jackson
On the Designware core, the channels are independent and not combined in higher registers. So as more channels are added, more registers need to be updated. Signed-off-by: Andrew Jackson --- sound/soc/dwc/designware_i2s.c | 32 +++- 1 files changed, 19

[PATCH 3/5] ASoC: dwc: Iterate over all channels

2014-12-03 Thread Andrew Jackson
On the Designware core, the channels are independent and not combined in higher registers. So as more channels are added, more registers need to be updated. Signed-off-by: Andrew Jackson andrew.jack...@arm.com --- sound/soc/dwc/designware_i2s.c | 32 +++- 1 files

Re: [PATCH 3/5] ASoC: dwc: Iterate over all channels

2014-12-03 Thread Mark Brown
On Wed, Dec 03, 2014 at 04:39:01PM +, Andrew Jackson wrote: + /* Iterate over set of channels - independently controlled. + */ + do { + if (substream-stream == SNDRV_PCM_STREAM_PLAYBACK) { + i2s_write_reg(dev-i2s_base, TCR(ch_reg), +

Re: [PATCH 3/5] ASoC: dwc: Iterate over all channels

2014-12-03 Thread rajeev kumar
On Wed, Dec 3, 2014 at 10:59 PM, Mark Brown broo...@kernel.org wrote: On Wed, Dec 03, 2014 at 04:39:01PM +, Andrew Jackson wrote: + /* Iterate over set of channels - independently controlled. + */ + do { + if (substream-stream == SNDRV_PCM_STREAM_PLAYBACK) { +