Re: [PATCH 3/5] drm/bridge: Add PTN3460 bridge driver

2013-10-10 Thread Mark Brown
On Thu, Oct 10, 2013 at 08:40:38PM +0900, Inki Dae wrote: > That is what I mentioned. Some boards _could control_ the actual regulator > for lvds-bridge, and that would be depended on how HW engineer designs the > board. For the driver this should be totally transparent - it should just control

RE: [PATCH 3/5] drm/bridge: Add PTN3460 bridge driver

2013-10-10 Thread Inki Dae
l.org; linux- > ker...@vger.kernel.org; 'DRI mailing list'; linux-arm- > ker...@lists.infradead.org > Subject: Re: [PATCH 3/5] drm/bridge: Add PTN3460 bridge driver > > On Thu, Oct 10, 2013 at 01:18:05PM +0900, Inki Dae wrote: > > > > > I still thin

Re: [PATCH 3/5] drm/bridge: Add PTN3460 bridge driver

2013-10-10 Thread Mark Brown
On Thu, Oct 10, 2013 at 01:18:05PM +0900, Inki Dae wrote: > > > I still think the pin could be replaced with a regulator. But > > > lvds-bridge node has "powerdown-gpio" property - it say this board > > > will use gpio pin - specific to board. So it seems no problem. > > No, don't model things t

RE: [PATCH 3/5] drm/bridge: Add PTN3460 bridge driver

2013-10-09 Thread Inki Dae
er...@vger.kernel.org; DRI mailing list; linux-arm- > ker...@lists.infradead.org > Subject: Re: [PATCH 3/5] drm/bridge: Add PTN3460 bridge driver > > On Fri, Oct 04, 2013 at 11:05:48AM +0900, Inki Dae wrote: > > 2013/10/4 Olof Johansson : > > > > "If PD_N

Re: [PATCH 3/5] drm/bridge: Add PTN3460 bridge driver

2013-10-09 Thread Mark Brown
On Fri, Oct 04, 2013 at 11:05:48AM +0900, Inki Dae wrote: > 2013/10/4 Olof Johansson : > > "If PD_N is LOW, then the device is in Deep power-down completely, > > even if supply rail is ON; for the device to be able to operate, the > > PD_N pin must be HIGH." > I still think the pin could be repla

Re: [PATCH 3/5] drm/bridge: Add PTN3460 bridge driver

2013-10-03 Thread Inki Dae
2013/10/4 Olof Johansson : > On Thu, Oct 3, 2013 at 10:39 AM, Inki Dae wrote: >> 2013/10/3 Sean Paul : >>> On Thu, Oct 3, 2013 at 9:55 AM, Inki Dae wrote: Can a regulator be used instead of gpio in other board case? >>> >>> No, not to my knowledge. >>> >> >> Hm.. plz check it out again.

Re: [PATCH 3/5] drm/bridge: Add PTN3460 bridge driver

2013-10-03 Thread Inki Dae
2013/10/4 Sean Paul : > On Thu, Oct 3, 2013 at 2:23 PM, Inki Dae wrote: >> 2013/10/4 Sean Paul : >>> On Thu, Oct 3, 2013 at 1:39 PM, Inki Dae wrote: 2013/10/3 Sean Paul : > On Thu, Oct 3, 2013 at 9:55 AM, Inki Dae wrote: >> Hi, thank you for your contribution and the below is my sho

Re: [PATCH 3/5] drm/bridge: Add PTN3460 bridge driver

2013-10-03 Thread Sean Paul
On Thu, Oct 3, 2013 at 2:23 PM, Inki Dae wrote: > 2013/10/4 Sean Paul : >> On Thu, Oct 3, 2013 at 1:39 PM, Inki Dae wrote: >>> 2013/10/3 Sean Paul : On Thu, Oct 3, 2013 at 9:55 AM, Inki Dae wrote: > Hi, thank you for your contribution and the below is my short comments, > > 2013

Re: [PATCH 3/5] drm/bridge: Add PTN3460 bridge driver

2013-10-03 Thread Inki Dae
2013/10/4 Sean Paul : > On Thu, Oct 3, 2013 at 1:39 PM, Inki Dae wrote: >> 2013/10/3 Sean Paul : >>> On Thu, Oct 3, 2013 at 9:55 AM, Inki Dae wrote: Hi, thank you for your contribution and the below is my short comments, 2013/10/2 Sean Paul : > This patch adds a drm_bridge driv

Re: [PATCH 3/5] drm/bridge: Add PTN3460 bridge driver

2013-10-03 Thread Sean Paul
On Thu, Oct 3, 2013 at 1:39 PM, Inki Dae wrote: > 2013/10/3 Sean Paul : >> On Thu, Oct 3, 2013 at 9:55 AM, Inki Dae wrote: >>> Hi, thank you for your contribution and the below is my short comments, >>> >>> 2013/10/2 Sean Paul : This patch adds a drm_bridge driver for the PTN3460 DisplayPort

Re: [PATCH 3/5] drm/bridge: Add PTN3460 bridge driver

2013-10-03 Thread Olof Johansson
On Thu, Oct 3, 2013 at 10:39 AM, Inki Dae wrote: > 2013/10/3 Sean Paul : >> On Thu, Oct 3, 2013 at 9:55 AM, Inki Dae wrote: >>> Can a regulator be used instead of gpio in other board case? >>> >> >> No, not to my knowledge. >> > > Hm.. plz check it out again. the gpio pin is specific to board, an

Re: [PATCH 3/5] drm/bridge: Add PTN3460 bridge driver

2013-10-03 Thread Inki Dae
2013/10/3 Sean Paul : > On Thu, Oct 3, 2013 at 9:55 AM, Inki Dae wrote: >> Hi, thank you for your contribution and the below is my short comments, >> >> 2013/10/2 Sean Paul : >>> This patch adds a drm_bridge driver for the PTN3460 DisplayPort to LVDS >>> bridge chip. >>> >>> Signed-off-by: Sean Pa

Re: [PATCH 3/5] drm/bridge: Add PTN3460 bridge driver

2013-10-03 Thread Sean Paul
On Thu, Oct 3, 2013 at 9:55 AM, Inki Dae wrote: > Hi, thank you for your contribution and the below is my short comments, > > 2013/10/2 Sean Paul : >> This patch adds a drm_bridge driver for the PTN3460 DisplayPort to LVDS >> bridge chip. >> >> Signed-off-by: Sean Paul >> --- >> .../devicetree/b

Re: [PATCH 3/5] drm/bridge: Add PTN3460 bridge driver

2013-10-03 Thread Inki Dae
Hi, thank you for your contribution and the below is my short comments, 2013/10/2 Sean Paul : > This patch adds a drm_bridge driver for the PTN3460 DisplayPort to LVDS > bridge chip. > > Signed-off-by: Sean Paul > --- > .../devicetree/bindings/drm/bridge/ptn3460.txt | 27 ++ > drivers/gpu/d

Re: [PATCH 3/5] drm/bridge: Add PTN3460 bridge driver

2013-10-02 Thread Olof Johansson
Hi, On Tue, Oct 1, 2013 at 4:40 PM, Sean Paul wrote: > This patch adds a drm_bridge driver for the PTN3460 DisplayPort to LVDS > bridge chip. > > Signed-off-by: Sean Paul > --- [...] > +Example: > + ptn3460-bridge@20 { Nit: Name is usually generic device name, i.e. "lvds-bridge" or som

[PATCH 3/5] drm/bridge: Add PTN3460 bridge driver

2013-10-01 Thread Sean Paul
This patch adds a drm_bridge driver for the PTN3460 DisplayPort to LVDS bridge chip. Signed-off-by: Sean Paul --- .../devicetree/bindings/drm/bridge/ptn3460.txt | 27 ++ drivers/gpu/drm/Kconfig| 2 + drivers/gpu/drm/Makefile | 1 + d