Re: [PATCH 3/5] mfd: tps65217: Add a dependency on OF

On Wednesday 07 June 2017 07:40 PM, Javier Martinez Canillas wrote: > Hello Keerthy, > > On Wed, Jun 7, 2017 at 3:45 PM, Keerthy wrote: > > [snip] > > I think you can remove the of_match_device checks in some drivers too i.e:

Re: [PATCH 3/5] mfd: tps65217: Add a dependency on OF

On Wednesday 07 June 2017 07:40 PM, Javier Martinez Canillas wrote: > Hello Keerthy, > > On Wed, Jun 7, 2017 at 3:45 PM, Keerthy wrote: > > [snip] > > I think you can remove the of_match_device checks in some drivers too i.e:

Re: [PATCH 3/5] mfd: tps65217: Add a dependency on OF

On Wed, Jun 7, 2017 at 4:10 PM, Javier Martinez Canillas wrote: [snip] >> >> chip_id = (unsigned long)match->data; >> > > ...but this particular driver only has a single entry in the OF table > and so you can just do: > > tps->id = TPS65217; > In fact, it seems that the

Re: [PATCH 3/5] mfd: tps65217: Add a dependency on OF

On Wed, Jun 7, 2017 at 4:10 PM, Javier Martinez Canillas wrote: [snip] >> >> chip_id = (unsigned long)match->data; >> > > ...but this particular driver only has a single entry in the OF table > and so you can just do: > > tps->id = TPS65217; > In fact, it seems that the whole chip id logic can

Re: [PATCH 3/5] mfd: tps65217: Add a dependency on OF

Hello Keerthy, On Wed, Jun 7, 2017 at 3:45 PM, Keerthy wrote: [snip] >>> >>> I think you can remove the of_match_device checks in some drivers too >>> >>> i.e: >>> >>>

Re: [PATCH 3/5] mfd: tps65217: Add a dependency on OF

Hello Keerthy, On Wed, Jun 7, 2017 at 3:45 PM, Keerthy wrote: [snip] >>> >>> I think you can remove the of_match_device checks in some drivers too >>> >>> i.e: >>> >>> http://elixir.free-electrons.com/linux/latest/source/drivers/mfd/tps65217.c#L330 >>

Re: [PATCH 3/5] mfd: tps65217: Add a dependency on OF

On Wednesday 07 June 2017 07:07 PM, Enric Balletbo Serra wrote: > 2017-06-07 13:24 GMT+02:00 Keerthy : >> >> >> On Wednesday 07 June 2017 04:08 PM, Lee Jones wrote: >>> On Wed, 07 Jun 2017, Lee Jones wrote: >>> On Wed, 07 Jun 2017, Keerthy wrote: > > > On

Re: [PATCH 3/5] mfd: tps65217: Add a dependency on OF

On Wednesday 07 June 2017 07:07 PM, Enric Balletbo Serra wrote: > 2017-06-07 13:24 GMT+02:00 Keerthy : >> >> >> On Wednesday 07 June 2017 04:08 PM, Lee Jones wrote: >>> On Wed, 07 Jun 2017, Lee Jones wrote: >>> On Wed, 07 Jun 2017, Keerthy wrote: > > > On Tuesday 06 June

Re: [PATCH 3/5] mfd: tps65217: Add a dependency on OF

2017-06-07 13:24 GMT+02:00 Keerthy : > > > On Wednesday 07 June 2017 04:08 PM, Lee Jones wrote: >> On Wed, 07 Jun 2017, Lee Jones wrote: >> >>> On Wed, 07 Jun 2017, Keerthy wrote: >>> On Tuesday 06 June 2017 08:34 PM, Enric Balletbo Serra wrote: > Hi Keerthy,

Re: [PATCH 3/5] mfd: tps65217: Add a dependency on OF

2017-06-07 13:24 GMT+02:00 Keerthy : > > > On Wednesday 07 June 2017 04:08 PM, Lee Jones wrote: >> On Wed, 07 Jun 2017, Lee Jones wrote: >> >>> On Wed, 07 Jun 2017, Keerthy wrote: >>> On Tuesday 06 June 2017 08:34 PM, Enric Balletbo Serra wrote: > Hi Keerthy, > > By

Re: [PATCH 3/5] mfd: tps65217: Add a dependency on OF

On Wednesday 07 June 2017 04:08 PM, Lee Jones wrote: > On Wed, 07 Jun 2017, Lee Jones wrote: > >> On Wed, 07 Jun 2017, Keerthy wrote: >> >>> >>> >>> On Tuesday 06 June 2017 08:34 PM, Enric Balletbo Serra wrote: Hi Keerthy, By change I was looking at this. Some comments below that

Re: [PATCH 3/5] mfd: tps65217: Add a dependency on OF

On Wednesday 07 June 2017 04:08 PM, Lee Jones wrote: > On Wed, 07 Jun 2017, Lee Jones wrote: > >> On Wed, 07 Jun 2017, Keerthy wrote: >> >>> >>> >>> On Tuesday 06 June 2017 08:34 PM, Enric Balletbo Serra wrote: Hi Keerthy, By change I was looking at this. Some comments below that

Re: [PATCH 3/5] mfd: tps65217: Add a dependency on OF

On Wednesday 07 June 2017 04:07 PM, Lee Jones wrote: > On Wed, 07 Jun 2017, Keerthy wrote: > >> >> >> On Tuesday 06 June 2017 08:34 PM, Enric Balletbo Serra wrote: >>> Hi Keerthy, >>> >>> By change I was looking at this. Some comments below that I think can >>> be applied to all patches in this

Re: [PATCH 3/5] mfd: tps65217: Add a dependency on OF

On Wednesday 07 June 2017 04:07 PM, Lee Jones wrote: > On Wed, 07 Jun 2017, Keerthy wrote: > >> >> >> On Tuesday 06 June 2017 08:34 PM, Enric Balletbo Serra wrote: >>> Hi Keerthy, >>> >>> By change I was looking at this. Some comments below that I think can >>> be applied to all patches in this

Re: [PATCH 3/5] mfd: tps65217: Add a dependency on OF

On Wed, 07 Jun 2017, Lee Jones wrote: > On Wed, 07 Jun 2017, Keerthy wrote: > > > > > > > On Tuesday 06 June 2017 08:34 PM, Enric Balletbo Serra wrote: > > > Hi Keerthy, > > > > > > By change I was looking at this. Some comments below that I think can > > > be applied to all patches in this

Re: [PATCH 3/5] mfd: tps65217: Add a dependency on OF

On Wed, 07 Jun 2017, Lee Jones wrote: > On Wed, 07 Jun 2017, Keerthy wrote: > > > > > > > On Tuesday 06 June 2017 08:34 PM, Enric Balletbo Serra wrote: > > > Hi Keerthy, > > > > > > By change I was looking at this. Some comments below that I think can > > > be applied to all patches in this

Re: [PATCH 3/5] mfd: tps65217: Add a dependency on OF

On Wed, 07 Jun 2017, Keerthy wrote: > > > On Tuesday 06 June 2017 08:34 PM, Enric Balletbo Serra wrote: > > Hi Keerthy, > > > > By change I was looking at this. Some comments below that I think can > > be applied to all patches in this series > > > > 2017-06-06 16:45 GMT+02:00 Keerthy

Re: [PATCH 3/5] mfd: tps65217: Add a dependency on OF

On Wed, 07 Jun 2017, Keerthy wrote: > > > On Tuesday 06 June 2017 08:34 PM, Enric Balletbo Serra wrote: > > Hi Keerthy, > > > > By change I was looking at this. Some comments below that I think can > > be applied to all patches in this series > > > > 2017-06-06 16:45 GMT+02:00 Keerthy : > >>

Re: [PATCH 3/5] mfd: tps65217: Add a dependency on OF

On Tuesday 06 June 2017 08:34 PM, Enric Balletbo Serra wrote: > Hi Keerthy, > > By change I was looking at this. Some comments below that I think can > be applied to all patches in this series > > 2017-06-06 16:45 GMT+02:00 Keerthy : >> Currently the driver boots only via

Re: [PATCH 3/5] mfd: tps65217: Add a dependency on OF

On Tuesday 06 June 2017 08:34 PM, Enric Balletbo Serra wrote: > Hi Keerthy, > > By change I was looking at this. Some comments below that I think can > be applied to all patches in this series > > 2017-06-06 16:45 GMT+02:00 Keerthy : >> Currently the driver boots only via device tree hence add

Re: [PATCH 3/5] mfd: tps65217: Add a dependency on OF

Hi Keerthy, By change I was looking at this. Some comments below that I think can be applied to all patches in this series 2017-06-06 16:45 GMT+02:00 Keerthy : > Currently the driver boots only via device tree hence add a > dependency on OF. > > Signed-off-by: Keerthy

Re: [PATCH 3/5] mfd: tps65217: Add a dependency on OF

Hi Keerthy, By change I was looking at this. Some comments below that I think can be applied to all patches in this series 2017-06-06 16:45 GMT+02:00 Keerthy : > Currently the driver boots only via device tree hence add a > dependency on OF. > > Signed-off-by: Keerthy > --- >

[PATCH 3/5] mfd: tps65217: Add a dependency on OF

Currently the driver boots only via device tree hence add a dependency on OF. Signed-off-by: Keerthy --- drivers/mfd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index 75b59f1..2d1425d 100644 ---

[PATCH 3/5] mfd: tps65217: Add a dependency on OF

Currently the driver boots only via device tree hence add a dependency on OF. Signed-off-by: Keerthy --- drivers/mfd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index 75b59f1..2d1425d 100644 --- a/drivers/mfd/Kconfig +++