Re: [PATCH 3/5] mm/migrate.c: fix potential indeterminate pte entry in migrate_vma_insert_page()

2021-03-23 Thread Miaohe Lin
On 2021/3/23 19:28, Miaohe Lin wrote: > On 2021/3/23 19:07, Alistair Popple wrote: >> On Tuesday, 23 March 2021 9:26:43 PM AEDT David Hildenbrand wrote: >>> On 20.03.21 10:36, Miaohe Lin wrote: If the zone device page does not belong to un-addressable device memory, the variable entry

Re: [PATCH 3/5] mm/migrate.c: fix potential indeterminate pte entry in migrate_vma_insert_page()

2021-03-23 Thread Miaohe Lin
On 2021/3/23 19:07, Alistair Popple wrote: > On Tuesday, 23 March 2021 9:26:43 PM AEDT David Hildenbrand wrote: >> On 20.03.21 10:36, Miaohe Lin wrote: >>> If the zone device page does not belong to un-addressable device memory, >>> the variable entry will be uninitialized and lead to

Re: [PATCH 3/5] mm/migrate.c: fix potential indeterminate pte entry in migrate_vma_insert_page()

2021-03-23 Thread Miaohe Lin
Hi: On 2021/3/23 18:26, David Hildenbrand wrote: > On 20.03.21 10:36, Miaohe Lin wrote: >> If the zone device page does not belong to un-addressable device memory, >> the variable entry will be uninitialized and lead to indeterminate pte >> entry ultimately. Fix this unexpectant case and warn

Re: [PATCH 3/5] mm/migrate.c: fix potential indeterminate pte entry in migrate_vma_insert_page()

2021-03-23 Thread Alistair Popple
On Tuesday, 23 March 2021 9:26:43 PM AEDT David Hildenbrand wrote: > On 20.03.21 10:36, Miaohe Lin wrote: > > If the zone device page does not belong to un-addressable device memory, > > the variable entry will be uninitialized and lead to indeterminate pte > > entry ultimately. Fix this

Re: [PATCH 3/5] mm/migrate.c: fix potential indeterminate pte entry in migrate_vma_insert_page()

2021-03-23 Thread David Hildenbrand
On 20.03.21 10:36, Miaohe Lin wrote: If the zone device page does not belong to un-addressable device memory, the variable entry will be uninitialized and lead to indeterminate pte entry ultimately. Fix this unexpectant case and warn about it. s/unexpectant/unexpected/ Fixes: df6ad69838fc

[PATCH 3/5] mm/migrate.c: fix potential indeterminate pte entry in migrate_vma_insert_page()

2021-03-20 Thread Miaohe Lin
If the zone device page does not belong to un-addressable device memory, the variable entry will be uninitialized and lead to indeterminate pte entry ultimately. Fix this unexpectant case and warn about it. Fixes: df6ad69838fc ("mm/device-public-memory: device memory cache coherent with CPU")