Re: [PATCH 3/5] zram: use zram_slot_lock instead of raw bit_spin_lock op

2017-04-03 Thread Minchan Kim
On Tue, Apr 04, 2017 at 11:18:51AM +0900, Sergey Senozhatsky wrote: > On (04/03/17 14:17), Minchan Kim wrote: > > With this clean-up phase, I want to use zram's wrapper function > > to lock table access which is more consistent with other zram's > > functions. > > > > Signed-off-by: Minchan Kim >

Re: [PATCH 3/5] zram: use zram_slot_lock instead of raw bit_spin_lock op

2017-04-03 Thread Sergey Senozhatsky
On (04/03/17 14:17), Minchan Kim wrote: > With this clean-up phase, I want to use zram's wrapper function > to lock table access which is more consistent with other zram's > functions. > > Signed-off-by: Minchan Kim Reviewed-by: Sergey Senozhatsky -ss

Re: [PATCH 3/5] zram: use zram_slot_lock instead of raw bit_spin_lock op

2017-04-03 Thread Sergey Senozhatsky
On (04/03/17 15:34), Minchan Kim wrote: [..] > > c) spin_locks probably have better fairness guarantees > > In fact, it wouldn't be an imporant because zram's slot lock contention > is not heavy. mostly agree. I think (and I may be mistaken) direct IO causes contention; but direct IO is probably

Re: [PATCH 3/5] zram: use zram_slot_lock instead of raw bit_spin_lock op

2017-04-02 Thread Minchan Kim
Hi Sergey, On Mon, Apr 03, 2017 at 03:08:58PM +0900, Sergey Senozhatsky wrote: > Hello Minchan, > > On (04/03/17 14:17), Minchan Kim wrote: > > With this clean-up phase, I want to use zram's wrapper function > > to lock table access which is more consistent with other zram's > > functions. > > w

Re: [PATCH 3/5] zram: use zram_slot_lock instead of raw bit_spin_lock op

2017-04-02 Thread Sergey Senozhatsky
Hello Minchan, On (04/03/17 14:17), Minchan Kim wrote: > With this clean-up phase, I want to use zram's wrapper function > to lock table access which is more consistent with other zram's > functions. which reminds me of... there was a discussion a long time ago, -rt people absolutely hate bit sp

[PATCH 3/5] zram: use zram_slot_lock instead of raw bit_spin_lock op

2017-04-02 Thread Minchan Kim
With this clean-up phase, I want to use zram's wrapper function to lock table access which is more consistent with other zram's functions. Signed-off-by: Minchan Kim --- drivers/block/zram/zram_drv.c | 42 -- 1 file changed, 28 insertions(+), 14 deletions(