Re: [PATCH 3/5 v2] Add the platform device support with RapidIO to MPC8641HPCN platform.

2007-06-28 Thread Segher Boessenkool
Of course, looking at the device tree, rapidio is a device, not a bus, because it does not have a device_type and it does not have any children of its own. It's a device _of course_, but it's also a bus parent, since it has a "#address-cells" not equal to zero (and, if this used real OF, it

Re: [PATCH 3/5 v2] Add the platform device support with RapidIO to MPC8641HPCN platform.

2007-06-28 Thread Arnd Bergmann
On Thursday 28 June 2007, Zhang Wei-r63237 wrote: > > > +static __init int mpc86xx_of_device_init(void) > > > +{ > > > +   return of_platform_bus_probe(NULL, mpc86xx_of_ids, NULL); > > > +} > > > > This will add any devices below the "fsl,rapidio-delta" device > > as an of_device. Is that

RE: [PATCH 3/5 v2] Add the platform device support with RapidIO to MPC8641HPCN platform.

2007-06-28 Thread Zhang Wei-r63237
Hi, Arnd, > > On Wednesday 27 June 2007, Zhang Wei wrote: > > +static struct of_device_id mpc86xx_of_ids[] = { > > +   { .type = "soc", }, > > +   { .compatible = "fsl,rapidio-delta", }, > > +   {}, > > +}; > > + > > +static __init int mpc86xx_of_device_init(void) > > +{ > > +   

RE: [PATCH 3/5 v2] Add the platform device support with RapidIO to MPC8641HPCN platform.

2007-06-28 Thread Zhang Wei-r63237
Hi, Arnd, On Wednesday 27 June 2007, Zhang Wei wrote: +static struct of_device_id mpc86xx_of_ids[] = { +   { .type = soc, }, +   { .compatible = fsl,rapidio-delta, }, +   {}, +}; + +static __init int mpc86xx_of_device_init(void) +{ +   return

Re: [PATCH 3/5 v2] Add the platform device support with RapidIO to MPC8641HPCN platform.

2007-06-28 Thread Arnd Bergmann
On Thursday 28 June 2007, Zhang Wei-r63237 wrote: +static __init int mpc86xx_of_device_init(void) +{ +   return of_platform_bus_probe(NULL, mpc86xx_of_ids, NULL); +} This will add any devices below the fsl,rapidio-delta device as an of_device. Is that what you actually want?

Re: [PATCH 3/5 v2] Add the platform device support with RapidIO to MPC8641HPCN platform.

2007-06-28 Thread Segher Boessenkool
Of course, looking at the device tree, rapidio is a device, not a bus, because it does not have a device_type and it does not have any children of its own. It's a device _of course_, but it's also a bus parent, since it has a #address-cells not equal to zero (and, if this used real OF, it

Re: [PATCH 3/5 v2] Add the platform device support with RapidIO to MPC8641HPCN platform.

2007-06-27 Thread Arnd Bergmann
On Wednesday 27 June 2007, Zhang Wei wrote: > +static struct of_device_id mpc86xx_of_ids[] = { > +   { .type = "soc", }, > +   { .compatible = "fsl,rapidio-delta", }, > +   {}, > +}; > + > +static __init int mpc86xx_of_device_init(void) > +{ > +   return of_platform_bus_probe(NULL,

[PATCH 3/5 v2] Add the platform device support with RapidIO to MPC8641HPCN platform.

2007-06-27 Thread Zhang Wei
Add the platform device support with RapidIO to MPC8641HPCN platform. Signed-off-by: Zhang Wei <[EMAIL PROTECTED]> --- arch/powerpc/platforms/86xx/mpc86xx_hpcn.c | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/arch/powerpc/platforms/86xx/mpc86xx_hpcn.c

[PATCH 3/5 v2] Add the platform device support with RapidIO to MPC8641HPCN platform.

2007-06-27 Thread Zhang Wei
Add the platform device support with RapidIO to MPC8641HPCN platform. Signed-off-by: Zhang Wei [EMAIL PROTECTED] --- arch/powerpc/platforms/86xx/mpc86xx_hpcn.c | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/arch/powerpc/platforms/86xx/mpc86xx_hpcn.c

Re: [PATCH 3/5 v2] Add the platform device support with RapidIO to MPC8641HPCN platform.

2007-06-27 Thread Arnd Bergmann
On Wednesday 27 June 2007, Zhang Wei wrote: +static struct of_device_id mpc86xx_of_ids[] = { +   { .type = soc, }, +   { .compatible = fsl,rapidio-delta, }, +   {}, +}; + +static __init int mpc86xx_of_device_init(void) +{ +   return of_platform_bus_probe(NULL,