Re: [PATCH 3/6] mm: display pkey in smaps if arch_pkeys_enabled() is true

2017-09-22 Thread Balbir Singh
On Fri, 15 Sep 2017 18:21:07 -0700 Ram Pai wrote: > +#ifdef CONFIG_ARCH_HAS_PKEYS > + if (arch_pkeys_enabled()) Sorry, I missed this bit in my previous review the patch makes sense > + seq_printf(m, "ProtectionKey: %8u\n", vma_pkey(vma)); > +#endif > +

Re: [PATCH 3/6] mm: display pkey in smaps if arch_pkeys_enabled() is true

2017-09-22 Thread Balbir Singh
On Fri, 15 Sep 2017 18:21:07 -0700 Ram Pai wrote: > +#ifdef CONFIG_ARCH_HAS_PKEYS > + if (arch_pkeys_enabled()) Sorry, I missed this bit in my previous review the patch makes sense > + seq_printf(m, "ProtectionKey: %8u\n", vma_pkey(vma)); > +#endif > + Balbir

Re: [PATCH 3/6] mm: display pkey in smaps if arch_pkeys_enabled() is true

2017-09-22 Thread Balbir Singh
On Fri, 15 Sep 2017 18:21:07 -0700 Ram Pai wrote: > Currently the architecture specific code is expected to > display the protection keys in smap for a given vma. > This can lead to redundant code and possibly to divergent > formats in which the key gets displayed. >

Re: [PATCH 3/6] mm: display pkey in smaps if arch_pkeys_enabled() is true

2017-09-22 Thread Balbir Singh
On Fri, 15 Sep 2017 18:21:07 -0700 Ram Pai wrote: > Currently the architecture specific code is expected to > display the protection keys in smap for a given vma. > This can lead to redundant code and possibly to divergent > formats in which the key gets displayed. > > This patch

[PATCH 3/6] mm: display pkey in smaps if arch_pkeys_enabled() is true

2017-09-15 Thread Ram Pai
Currently the architecture specific code is expected to display the protection keys in smap for a given vma. This can lead to redundant code and possibly to divergent formats in which the key gets displayed. This patch changes the implementation. It displays the pkey only if the

[PATCH 3/6] mm: display pkey in smaps if arch_pkeys_enabled() is true

2017-09-15 Thread Ram Pai
Currently the architecture specific code is expected to display the protection keys in smap for a given vma. This can lead to redundant code and possibly to divergent formats in which the key gets displayed. This patch changes the implementation. It displays the pkey only if the