Re: [PATCH 3/6] net: stmmac: sun8i: Use devm_regulator_get for PHY regulator

2019-08-20 Thread Ondřej Jirman
Hi, On Tue, Aug 20, 2019 at 05:57:44PM +0200, Andrew Lunn wrote: > On Tue, Aug 20, 2019 at 05:47:14PM +0200, Ondřej Jirman wrote: > > Hi Andrew, > > > > On Tue, Aug 20, 2019 at 05:39:39PM +0200, Andrew Lunn wrote: > > > On Tue, Aug 20, 2019 at 04:53:40PM +0200, meg...@megous.com wrote: > > > >

Re: [PATCH 3/6] net: stmmac: sun8i: Use devm_regulator_get for PHY regulator

2019-08-20 Thread Andrew Lunn
On Tue, Aug 20, 2019 at 05:47:14PM +0200, Ondřej Jirman wrote: > Hi Andrew, > > On Tue, Aug 20, 2019 at 05:39:39PM +0200, Andrew Lunn wrote: > > On Tue, Aug 20, 2019 at 04:53:40PM +0200, meg...@megous.com wrote: > > > From: Ondrej Jirman > > > > > > Use devm_regulator_get instead of

Re: [PATCH 3/6] net: stmmac: sun8i: Use devm_regulator_get for PHY regulator

2019-08-20 Thread Ondřej Jirman
On Tue, Aug 20, 2019 at 05:39:39PM +0200, Andrew Lunn wrote: > On Tue, Aug 20, 2019 at 04:53:40PM +0200, meg...@megous.com wrote: > > From: Ondrej Jirman > > > > Use devm_regulator_get instead of devm_regulator_get_optional and rely > > on dummy supply. This avoids NULL checks before

Re: [PATCH 3/6] net: stmmac: sun8i: Use devm_regulator_get for PHY regulator

2019-08-20 Thread Ondřej Jirman
Hi Andrew, On Tue, Aug 20, 2019 at 05:39:39PM +0200, Andrew Lunn wrote: > On Tue, Aug 20, 2019 at 04:53:40PM +0200, meg...@megous.com wrote: > > From: Ondrej Jirman > > > > Use devm_regulator_get instead of devm_regulator_get_optional and rely > > on dummy supply. This avoids NULL checks before

Re: [PATCH 3/6] net: stmmac: sun8i: Use devm_regulator_get for PHY regulator

2019-08-20 Thread Andrew Lunn
On Tue, Aug 20, 2019 at 04:53:40PM +0200, meg...@megous.com wrote: > From: Ondrej Jirman > > Use devm_regulator_get instead of devm_regulator_get_optional and rely > on dummy supply. This avoids NULL checks before regulator_enable/disable > calls. Hi Ondrej What do you mean by a dummy supply?

[PATCH 3/6] net: stmmac: sun8i: Use devm_regulator_get for PHY regulator

2019-08-20 Thread megous
From: Ondrej Jirman Use devm_regulator_get instead of devm_regulator_get_optional and rely on dummy supply. This avoids NULL checks before regulator_enable/disable calls. This path also improves error reporting, because we now report both use of dummy supply and error during registration with