Re: [PATCH 3/6] virtio_console: free buffers after reset

2018-04-23 Thread Jason Wang
On 2018年04月21日 02:18, Michael S. Tsirkin wrote: Console driver is out of spec. The spec says: A driver MUST NOT decrement the available idx on a live virtqueue (ie. there is no way to “unexpose” buffers). and it does exactly that by trying to detach unused buffers without doing

Re: [PATCH 3/6] virtio_console: free buffers after reset

2018-04-23 Thread Jason Wang
On 2018年04月21日 02:18, Michael S. Tsirkin wrote: Console driver is out of spec. The spec says: A driver MUST NOT decrement the available idx on a live virtqueue (ie. there is no way to “unexpose” buffers). and it does exactly that by trying to detach unused buffers without doing

[PATCH 3/6] virtio_console: free buffers after reset

2018-04-20 Thread Michael S. Tsirkin
Console driver is out of spec. The spec says: A driver MUST NOT decrement the available idx on a live virtqueue (ie. there is no way to “unexpose” buffers). and it does exactly that by trying to detach unused buffers without doing a device reset first. Defer detaching the buffers

[PATCH 3/6] virtio_console: free buffers after reset

2018-04-20 Thread Michael S. Tsirkin
Console driver is out of spec. The spec says: A driver MUST NOT decrement the available idx on a live virtqueue (ie. there is no way to “unexpose” buffers). and it does exactly that by trying to detach unused buffers without doing a device reset first. Defer detaching the buffers