Re: [PATCH 3/7] perf: Migrate perf to use new tick dependency mask model

2015-12-02 Thread Peter Zijlstra
On Wed, Dec 02, 2015 at 06:03:14PM +0100, Frederic Weisbecker wrote: > Right, I can do either that or I can move the dependency to the CPU level > and count nr_freq to the cpu_ctx when any ctx gets scheduled in/out. Then > everytime we inc and nr_freq == 1, we set the dependency (all that should >

Re: [PATCH 3/7] perf: Migrate perf to use new tick dependency mask model

2015-12-02 Thread Frederic Weisbecker
On Wed, Dec 02, 2015 at 05:17:58PM +0100, Peter Zijlstra wrote: > On Wed, Nov 25, 2015 at 01:34:30PM +0100, Frederic Weisbecker wrote: > > On Tue, Nov 24, 2015 at 11:19:33AM -0500, Chris Metcalf wrote: > > > > It would be helpful to have a comment explaining why these two > > > can't race with eac

Re: [PATCH 3/7] perf: Migrate perf to use new tick dependency mask model

2015-12-02 Thread Peter Zijlstra
On Wed, Nov 25, 2015 at 01:34:30PM +0100, Frederic Weisbecker wrote: > On Tue, Nov 24, 2015 at 11:19:33AM -0500, Chris Metcalf wrote: > > It would be helpful to have a comment explaining why these two > > can't race with each other, e.g. this race: > > > > [cpu 1] atomic_dec_and_test > > [cpu 2]

Re: [PATCH 3/7] perf: Migrate perf to use new tick dependency mask model

2015-11-25 Thread Frederic Weisbecker
On Tue, Nov 24, 2015 at 11:19:33AM -0500, Chris Metcalf wrote: > On 11/13/2015 09:22 AM, Frederic Weisbecker wrote: > >Instead of providing asynchronous checks for the nohz subsystem to verify > >perf event tick dependency, migrate perf to the new mask. > > > >Perf needs the tick for two situations

Re: [PATCH 3/7] perf: Migrate perf to use new tick dependency mask model

2015-11-24 Thread Chris Metcalf
On 11/13/2015 09:22 AM, Frederic Weisbecker wrote: Instead of providing asynchronous checks for the nohz subsystem to verify perf event tick dependency, migrate perf to the new mask. Perf needs the tick for two situations: 1) Freq events. We could set the tick dependency when those are installe

[PATCH 3/7] perf: Migrate perf to use new tick dependency mask model

2015-11-13 Thread Frederic Weisbecker
Instead of providing asynchronous checks for the nohz subsystem to verify perf event tick dependency, migrate perf to the new mask. Perf needs the tick for two situations: 1) Freq events. We could set the tick dependency when those are installed on a CPU context. But setting a global dependency o