Re: [PATCH 3/7] phy: qcom-qmp: Fix phy pipe clock name

2017-07-18 Thread Vivek Gautam
Hi, On Mon, Jul 17, 2017 at 5:33 PM, Varadarajan Narayanan wrote: > Presently, the phy pipe clock's name is assumed to be either > usb3_phy_pipe_clk_src or pcie_XX_pipe_clk_src (where XX is the > phy lane's number). However, this will not work if an SoC has > more than

Re: [PATCH 3/7] phy: qcom-qmp: Fix phy pipe clock name

2017-07-18 Thread Vivek Gautam
Hi, On Mon, Jul 17, 2017 at 5:33 PM, Varadarajan Narayanan wrote: > Presently, the phy pipe clock's name is assumed to be either > usb3_phy_pipe_clk_src or pcie_XX_pipe_clk_src (where XX is the > phy lane's number). However, this will not work if an SoC has > more than one instance of the phy.

Re: [PATCH 3/7] phy: qcom-qmp: Fix phy pipe clock name

2017-07-18 Thread Vivek Gautam
On Tue, Jul 18, 2017 at 10:26 PM, Bjorn Andersson wrote: > On Tue 18 Jul 01:54 PDT 2017, Varadarajan Narayanan wrote: >> On Mon, Jul 17, 2017 at 03:30:47PM -0700, Bjorn Andersson wrote: > [..] >> > >> > This would be the case for any existing dts files, so you're not

Re: [PATCH 3/7] phy: qcom-qmp: Fix phy pipe clock name

2017-07-18 Thread Vivek Gautam
On Tue, Jul 18, 2017 at 10:26 PM, Bjorn Andersson wrote: > On Tue 18 Jul 01:54 PDT 2017, Varadarajan Narayanan wrote: >> On Mon, Jul 17, 2017 at 03:30:47PM -0700, Bjorn Andersson wrote: > [..] >> > >> > This would be the case for any existing dts files, so you're not allowed >> > to treat this as

Re: [PATCH 3/7] phy: qcom-qmp: Fix phy pipe clock name

2017-07-18 Thread Bjorn Andersson
On Tue 18 Jul 01:54 PDT 2017, Varadarajan Narayanan wrote: > On Mon, Jul 17, 2017 at 03:30:47PM -0700, Bjorn Andersson wrote: [..] > > > > This would be the case for any existing dts files, so you're not allowed > > to treat this as an error. > > Since, there are no dts files that presently

Re: [PATCH 3/7] phy: qcom-qmp: Fix phy pipe clock name

2017-07-18 Thread Bjorn Andersson
On Tue 18 Jul 01:54 PDT 2017, Varadarajan Narayanan wrote: > On Mon, Jul 17, 2017 at 03:30:47PM -0700, Bjorn Andersson wrote: [..] > > > > This would be the case for any existing dts files, so you're not allowed > > to treat this as an error. > > Since, there are no dts files that presently

Re: [PATCH 3/7] phy: qcom-qmp: Fix phy pipe clock name

2017-07-18 Thread Varadarajan Narayanan
Bjorn, On Mon, Jul 17, 2017 at 03:30:47PM -0700, Bjorn Andersson wrote: > On Mon 17 Jul 05:03 PDT 2017, Varadarajan Narayanan wrote: > > > Presently, the phy pipe clock's name is assumed to be either > > usb3_phy_pipe_clk_src or pcie_XX_pipe_clk_src (where XX is the > > phy lane's number).

Re: [PATCH 3/7] phy: qcom-qmp: Fix phy pipe clock name

2017-07-18 Thread Varadarajan Narayanan
Bjorn, On Mon, Jul 17, 2017 at 03:30:47PM -0700, Bjorn Andersson wrote: > On Mon 17 Jul 05:03 PDT 2017, Varadarajan Narayanan wrote: > > > Presently, the phy pipe clock's name is assumed to be either > > usb3_phy_pipe_clk_src or pcie_XX_pipe_clk_src (where XX is the > > phy lane's number).

Re: [PATCH 3/7] phy: qcom-qmp: Fix phy pipe clock name

2017-07-17 Thread Bjorn Andersson
On Mon 17 Jul 05:03 PDT 2017, Varadarajan Narayanan wrote: > Presently, the phy pipe clock's name is assumed to be either > usb3_phy_pipe_clk_src or pcie_XX_pipe_clk_src (where XX is the > phy lane's number). However, this will not work if an SoC has > more than one instance of the phy. Hence,

Re: [PATCH 3/7] phy: qcom-qmp: Fix phy pipe clock name

2017-07-17 Thread Bjorn Andersson
On Mon 17 Jul 05:03 PDT 2017, Varadarajan Narayanan wrote: > Presently, the phy pipe clock's name is assumed to be either > usb3_phy_pipe_clk_src or pcie_XX_pipe_clk_src (where XX is the > phy lane's number). However, this will not work if an SoC has > more than one instance of the phy. Hence,

[PATCH 3/7] phy: qcom-qmp: Fix phy pipe clock name

2017-07-17 Thread Varadarajan Narayanan
Presently, the phy pipe clock's name is assumed to be either usb3_phy_pipe_clk_src or pcie_XX_pipe_clk_src (where XX is the phy lane's number). However, this will not work if an SoC has more than one instance of the phy. Hence, instead of assuming the name of the clock, fetch it from the DT.

[PATCH 3/7] phy: qcom-qmp: Fix phy pipe clock name

2017-07-17 Thread Varadarajan Narayanan
Presently, the phy pipe clock's name is assumed to be either usb3_phy_pipe_clk_src or pcie_XX_pipe_clk_src (where XX is the phy lane's number). However, this will not work if an SoC has more than one instance of the phy. Hence, instead of assuming the name of the clock, fetch it from the DT.