Re: [PATCH 3/8] irq-imgpdc: add ImgTec PDC irqchip driver

2013-04-25 Thread James Hogan
Hi Thomas, On 23/04/13 16:09, Thomas Gleixner wrote: > On Tue, 23 Apr 2013, James Hogan wrote: >> +pdc_write(priv, PDC_IRQ_ROUTE, irq_route); > >> +spin_unlock_irqrestore(>lock, flags); >> +} >> + >> +static void perip_irq_unmask(struct irq_data *data) >> +{ >> +struct pdc_intc_priv

Re: [PATCH 3/8] irq-imgpdc: add ImgTec PDC irqchip driver

2013-04-25 Thread James Hogan
Hi Thomas, On 23/04/13 16:09, Thomas Gleixner wrote: On Tue, 23 Apr 2013, James Hogan wrote: +pdc_write(priv, PDC_IRQ_ROUTE, irq_route); +spin_unlock_irqrestore(priv-lock, flags); +} + +static void perip_irq_unmask(struct irq_data *data) +{ +struct pdc_intc_priv *priv =

Re: [PATCH 3/8] irq-imgpdc: add ImgTec PDC irqchip driver

2013-04-24 Thread Thomas Gleixner
On Wed, 24 Apr 2013, James Hogan wrote: > Thanks for the review Thomas! > > On 23/04/13 16:09, Thomas Gleixner wrote: > > On Tue, 23 Apr 2013, James Hogan wrote: >> + spinlock_t lock; > > > > raw_spinlock_t please > > Okay. > > If I understand right, this would be because on

Re: [PATCH 3/8] irq-imgpdc: add ImgTec PDC irqchip driver

2013-04-24 Thread James Hogan
Thanks for the review Thomas! On 23/04/13 16:09, Thomas Gleixner wrote: > On Tue, 23 Apr 2013, James Hogan wrote: >> +/** >> + * struct pdc_intc_priv - private pdc interrupt data. >> + * @nr_perips: Number of peripheral interrupt signals. >> + * @nr_syswakes:Number of syswake

Re: [PATCH 3/8] irq-imgpdc: add ImgTec PDC irqchip driver

2013-04-24 Thread James Hogan
Thanks for the review Thomas! On 23/04/13 16:09, Thomas Gleixner wrote: On Tue, 23 Apr 2013, James Hogan wrote: +/** + * struct pdc_intc_priv - private pdc interrupt data. + * @nr_perips: Number of peripheral interrupt signals. + * @nr_syswakes:Number of syswake signals. +

Re: [PATCH 3/8] irq-imgpdc: add ImgTec PDC irqchip driver

2013-04-24 Thread Thomas Gleixner
On Wed, 24 Apr 2013, James Hogan wrote: Thanks for the review Thomas! On 23/04/13 16:09, Thomas Gleixner wrote: On Tue, 23 Apr 2013, James Hogan wrote: + spinlock_t lock; raw_spinlock_t please Okay. If I understand right, this would be because on RT, spinlock_t

Re: [PATCH 3/8] irq-imgpdc: add ImgTec PDC irqchip driver

2013-04-23 Thread Thomas Gleixner
On Tue, 23 Apr 2013, James Hogan wrote: > +/** > + * struct pdc_intc_priv - private pdc interrupt data. > + * @nr_perips: Number of peripheral interrupt signals. > + * @nr_syswakes: Number of syswake signals. > + * @perip_irqs: List of peripheral IRQ numbers handled.

[PATCH 3/8] irq-imgpdc: add ImgTec PDC irqchip driver

2013-04-23 Thread James Hogan
Add irqchip driver for the ImgTec PowerDown Controller (PDC) as found in the TZ1090. The PDC has a number of general system wakeup (SysWake) interrupts (which would for example be connected to a power button or an external peripheral), and a number of peripheral interrupts which can also wake the

[PATCH 3/8] irq-imgpdc: add ImgTec PDC irqchip driver

2013-04-23 Thread James Hogan
Add irqchip driver for the ImgTec PowerDown Controller (PDC) as found in the TZ1090. The PDC has a number of general system wakeup (SysWake) interrupts (which would for example be connected to a power button or an external peripheral), and a number of peripheral interrupts which can also wake the

Re: [PATCH 3/8] irq-imgpdc: add ImgTec PDC irqchip driver

2013-04-23 Thread Thomas Gleixner
On Tue, 23 Apr 2013, James Hogan wrote: +/** + * struct pdc_intc_priv - private pdc interrupt data. + * @nr_perips: Number of peripheral interrupt signals. + * @nr_syswakes: Number of syswake signals. + * @perip_irqs: List of peripheral IRQ numbers handled. + *