Re: [PATCH 3.10 06/31] tcp: tcp_make_synack() should clear skb->tstamp

2015-04-26 Thread David Miller
From: Willy Tarreau Date: Mon, 27 Apr 2015 06:02:22 +0200 > Hi Greg, > > On Sun, Apr 26, 2015 at 03:46:26PM +0200, Greg Kroah-Hartman wrote: >> 3.10-stable review patch. If anyone has any objections, please let me know. >> >> -- >> >> From: Eric Dumazet >> >> [ Upstream

Re: [PATCH 3.10 06/31] tcp: tcp_make_synack() should clear skb->tstamp

2015-04-26 Thread Eric Dumazet
Right. Bug was introduced in 3.18, the Fixes: tag tells us ;) git describe --contains 7faee5c0d514 v3.18-rc1~52^2~148^2 Note that it does not hurt having this backport to prior kernel versions. Field is already 0 after skb allocation/cloning. On Sun, Apr 26, 2015 at 9:02 PM, Willy Tarreau

Re: [PATCH 3.10 06/31] tcp: tcp_make_synack() should clear skb->tstamp

2015-04-26 Thread Willy Tarreau
Hi Greg, On Sun, Apr 26, 2015 at 03:46:26PM +0200, Greg Kroah-Hartman wrote: > 3.10-stable review patch. If anyone has any objections, please let me know. > > -- > > From: Eric Dumazet > > [ Upstream commit b50edd7812852d989f2ef09dcfc729690f54a42d ] > > I noticed tcpdump was

[PATCH 3.10 06/31] tcp: tcp_make_synack() should clear skb->tstamp

2015-04-26 Thread Greg Kroah-Hartman
3.10-stable review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet [ Upstream commit b50edd7812852d989f2ef09dcfc729690f54a42d ] I noticed tcpdump was giving funky timestamps for locally generated SYNACK messages on loopback interface.

[PATCH 3.10 06/31] tcp: tcp_make_synack() should clear skb-tstamp

2015-04-26 Thread Greg Kroah-Hartman
3.10-stable review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet eduma...@google.com [ Upstream commit b50edd7812852d989f2ef09dcfc729690f54a42d ] I noticed tcpdump was giving funky timestamps for locally generated SYNACK messages on loopback

Re: [PATCH 3.10 06/31] tcp: tcp_make_synack() should clear skb-tstamp

2015-04-26 Thread Willy Tarreau
Hi Greg, On Sun, Apr 26, 2015 at 03:46:26PM +0200, Greg Kroah-Hartman wrote: 3.10-stable review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet eduma...@google.com [ Upstream commit b50edd7812852d989f2ef09dcfc729690f54a42d ] I noticed

Re: [PATCH 3.10 06/31] tcp: tcp_make_synack() should clear skb-tstamp

2015-04-26 Thread David Miller
From: Willy Tarreau w...@1wt.eu Date: Mon, 27 Apr 2015 06:02:22 +0200 Hi Greg, On Sun, Apr 26, 2015 at 03:46:26PM +0200, Greg Kroah-Hartman wrote: 3.10-stable review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet eduma...@google.com [

Re: [PATCH 3.10 06/31] tcp: tcp_make_synack() should clear skb-tstamp

2015-04-26 Thread Eric Dumazet
Right. Bug was introduced in 3.18, the Fixes: tag tells us ;) git describe --contains 7faee5c0d514 v3.18-rc1~52^2~148^2 Note that it does not hurt having this backport to prior kernel versions. Field is already 0 after skb allocation/cloning. On Sun, Apr 26, 2015 at 9:02 PM, Willy Tarreau