Re: [PATCH 3.18 18/52] HID: i2c-hid: fix size check and type usage

> - if (ret_size > size) { > + if ((ret_size > size) || (ret_size <= 2)) { > dev_err(>client->dev, "%s: incomplete report (%d/%d)\n", > __func__, size, ret_size); > return; This change spams in the dmesg output. Could you please undo this change? Or - if ((ret_size > size) || (ret_size <= 2)) {

Re: [PATCH 3.18 18/52] HID: i2c-hid: fix size check and type usage

> - if (ret_size > size) { > + if ((ret_size > size) || (ret_size <= 2)) { > dev_err(>client->dev, "%s: incomplete report (%d/%d)\n", > __func__, size, ret_size); > return; This change spams in the dmesg output. Could you please undo this change? Or - if ((ret_size > size) || (ret_size <= 2)) {

[PATCH 3.18 18/52] HID: i2c-hid: fix size check and type usage

3.18-stable review patch. If anyone has any objections, please let me know. -- From: Aaron Ma commit ac75a041048b8c1f7418e27621ca5efda8571043 upstream. When convert char array with signed int, if the inbuf[x] is negative then upper bits will be set to

[PATCH 3.18 18/52] HID: i2c-hid: fix size check and type usage

3.18-stable review patch. If anyone has any objections, please let me know. -- From: Aaron Ma commit ac75a041048b8c1f7418e27621ca5efda8571043 upstream. When convert char array with signed int, if the inbuf[x] is negative then upper bits will be set to 1. Fix this by using u8