Re: [Bulk] Re: [PATCH 4/10] compiler-gcc{3,4}.h: Use GCC_VERSION macro

2012-10-03 Thread David Rientjes
On Fri, 28 Sep 2012, Josh Triplett wrote: > GCC 4.1.0 and 4.1.1 miscompiling __weak has nothing to do with > __compiletime_object_size; why should *this* version check exclude those > versions? > Agreed, we shouldn't be relying on any #error directives to fail the build and then try to factor

Re: [Bulk] Re: [PATCH 4/10] compiler-gcc{3,4}.h: Use GCC_VERSION macro

2012-10-03 Thread David Rientjes
On Fri, 28 Sep 2012, Josh Triplett wrote: GCC 4.1.0 and 4.1.1 miscompiling __weak has nothing to do with __compiletime_object_size; why should *this* version check exclude those versions? Agreed, we shouldn't be relying on any #error directives to fail the build and then try to factor

Re: [Bulk] Re: [PATCH 4/10] compiler-gcc{3,4}.h: Use GCC_VERSION macro

2012-09-28 Thread Josh Triplett
On Fri, Sep 28, 2012 at 07:31:53PM -0500, Daniel Santos wrote: > On 09/28/2012 07:20 PM, Josh Triplett wrote: > > On Fri, Sep 28, 2012 at 06:20:05PM -0500, Daniel Santos wrote: > >> --- a/include/linux/compiler-gcc4.h > >> +++ b/include/linux/compiler-gcc4.h > >> @@ -13,11 +13,11 @@ > >> #define

Re: [Bulk] Re: [PATCH 4/10] compiler-gcc{3,4}.h: Use GCC_VERSION macro

2012-09-28 Thread Daniel Santos
On 09/28/2012 07:20 PM, Josh Triplett wrote: > On Fri, Sep 28, 2012 at 06:20:05PM -0500, Daniel Santos wrote: >> --- a/include/linux/compiler-gcc4.h >> +++ b/include/linux/compiler-gcc4.h >> @@ -13,11 +13,11 @@ >> #define __must_check__attribute__((warn_unused_result)) >> #define

Re: [PATCH 4/10] compiler-gcc{3,4}.h: Use GCC_VERSION macro

2012-09-28 Thread Josh Triplett
On Fri, Sep 28, 2012 at 06:20:05PM -0500, Daniel Santos wrote: > --- a/include/linux/compiler-gcc4.h > +++ b/include/linux/compiler-gcc4.h > @@ -13,11 +13,11 @@ > #define __must_check __attribute__((warn_unused_result)) > #define __compiler_offsetof(a,b) __builtin_offsetof(a,b) >

[PATCH 4/10] compiler-gcc{3,4}.h: Use GCC_VERSION macro

2012-09-28 Thread Daniel Santos
Using GCC_VERSION reduces complexity, is easier to read and is GCC's recommended mechanism for doing version checks. (Just don't ask me why they didn't define it in the first place.) This also makes it easy to merge compiler-gcc{3,4}.h should somebody want to. Signed-off-by: Daniel Santos ---

[PATCH 4/10] compiler-gcc{3,4}.h: Use GCC_VERSION macro

2012-09-28 Thread Daniel Santos
Using GCC_VERSION reduces complexity, is easier to read and is GCC's recommended mechanism for doing version checks. (Just don't ask me why they didn't define it in the first place.) This also makes it easy to merge compiler-gcc{3,4}.h should somebody want to. Signed-off-by: Daniel Santos

Re: [PATCH 4/10] compiler-gcc{3,4}.h: Use GCC_VERSION macro

2012-09-28 Thread Josh Triplett
On Fri, Sep 28, 2012 at 06:20:05PM -0500, Daniel Santos wrote: --- a/include/linux/compiler-gcc4.h +++ b/include/linux/compiler-gcc4.h @@ -13,11 +13,11 @@ #define __must_check __attribute__((warn_unused_result)) #define __compiler_offsetof(a,b) __builtin_offsetof(a,b)

Re: [Bulk] Re: [PATCH 4/10] compiler-gcc{3,4}.h: Use GCC_VERSION macro

2012-09-28 Thread Daniel Santos
On 09/28/2012 07:20 PM, Josh Triplett wrote: On Fri, Sep 28, 2012 at 06:20:05PM -0500, Daniel Santos wrote: --- a/include/linux/compiler-gcc4.h +++ b/include/linux/compiler-gcc4.h @@ -13,11 +13,11 @@ #define __must_check__attribute__((warn_unused_result)) #define

Re: [Bulk] Re: [PATCH 4/10] compiler-gcc{3,4}.h: Use GCC_VERSION macro

2012-09-28 Thread Josh Triplett
On Fri, Sep 28, 2012 at 07:31:53PM -0500, Daniel Santos wrote: On 09/28/2012 07:20 PM, Josh Triplett wrote: On Fri, Sep 28, 2012 at 06:20:05PM -0500, Daniel Santos wrote: --- a/include/linux/compiler-gcc4.h +++ b/include/linux/compiler-gcc4.h @@ -13,11 +13,11 @@ #define __must_check