On Fri, 28 Sep 2012, Josh Triplett wrote:
> GCC 4.1.0 and 4.1.1 miscompiling __weak has nothing to do with
> __compiletime_object_size; why should *this* version check exclude those
> versions?
>
Agreed, we shouldn't be relying on any #error directives to fail the build
and then try to factor
On Fri, 28 Sep 2012, Josh Triplett wrote:
GCC 4.1.0 and 4.1.1 miscompiling __weak has nothing to do with
__compiletime_object_size; why should *this* version check exclude those
versions?
Agreed, we shouldn't be relying on any #error directives to fail the build
and then try to factor
On Fri, Sep 28, 2012 at 07:31:53PM -0500, Daniel Santos wrote:
> On 09/28/2012 07:20 PM, Josh Triplett wrote:
> > On Fri, Sep 28, 2012 at 06:20:05PM -0500, Daniel Santos wrote:
> >> --- a/include/linux/compiler-gcc4.h
> >> +++ b/include/linux/compiler-gcc4.h
> >> @@ -13,11 +13,11 @@
> >> #define
On 09/28/2012 07:20 PM, Josh Triplett wrote:
> On Fri, Sep 28, 2012 at 06:20:05PM -0500, Daniel Santos wrote:
>> --- a/include/linux/compiler-gcc4.h
>> +++ b/include/linux/compiler-gcc4.h
>> @@ -13,11 +13,11 @@
>> #define __must_check__attribute__((warn_unused_result))
>> #define
On Fri, Sep 28, 2012 at 06:20:05PM -0500, Daniel Santos wrote:
> --- a/include/linux/compiler-gcc4.h
> +++ b/include/linux/compiler-gcc4.h
> @@ -13,11 +13,11 @@
> #define __must_check __attribute__((warn_unused_result))
> #define __compiler_offsetof(a,b) __builtin_offsetof(a,b)
>
Using GCC_VERSION reduces complexity, is easier to read and is GCC's
recommended mechanism for doing version checks. (Just don't ask me why
they didn't define it in the first place.) This also makes it easy to
merge compiler-gcc{3,4}.h should somebody want to.
Signed-off-by: Daniel Santos
---
Using GCC_VERSION reduces complexity, is easier to read and is GCC's
recommended mechanism for doing version checks. (Just don't ask me why
they didn't define it in the first place.) This also makes it easy to
merge compiler-gcc{3,4}.h should somebody want to.
Signed-off-by: Daniel Santos
On Fri, Sep 28, 2012 at 06:20:05PM -0500, Daniel Santos wrote:
--- a/include/linux/compiler-gcc4.h
+++ b/include/linux/compiler-gcc4.h
@@ -13,11 +13,11 @@
#define __must_check __attribute__((warn_unused_result))
#define __compiler_offsetof(a,b) __builtin_offsetof(a,b)
On 09/28/2012 07:20 PM, Josh Triplett wrote:
On Fri, Sep 28, 2012 at 06:20:05PM -0500, Daniel Santos wrote:
--- a/include/linux/compiler-gcc4.h
+++ b/include/linux/compiler-gcc4.h
@@ -13,11 +13,11 @@
#define __must_check__attribute__((warn_unused_result))
#define
On Fri, Sep 28, 2012 at 07:31:53PM -0500, Daniel Santos wrote:
On 09/28/2012 07:20 PM, Josh Triplett wrote:
On Fri, Sep 28, 2012 at 06:20:05PM -0500, Daniel Santos wrote:
--- a/include/linux/compiler-gcc4.h
+++ b/include/linux/compiler-gcc4.h
@@ -13,11 +13,11 @@
#define __must_check
10 matches
Mail list logo