Re: [PATCH 4/4] ASoc: kirkwood: add DT support

2013-07-26 Thread Mark Brown
On Fri, Jul 26, 2013 at 12:05:33AM +0100, Russell King - ARM Linux wrote: > On Thu, Jul 25, 2013 at 08:19:05PM +0100, Mark Brown wrote: > > On Thu, Jul 25, 2013 at 11:14:59AM +0200, Jean-Francois Moine wrote: > > > + if (np) { > > > + priv->burst = 128; /* might be 32 or 128 *

Re: [PATCH 4/4] ASoc: kirkwood: add DT support

2013-07-26 Thread Jean-Francois Moine
On Fri, 26 Jul 2013 10:21:56 +0100 Russell King - ARM Linux wrote: > On Fri, Jul 26, 2013 at 11:09:13AM +0200, Jean-Francois Moine wrote: > > The A510 documentation uses the names "DCO PLL" for the internal clock > > and "AU_EXTCLK" for the external clock. So, what about "dcopll" and > > "extclk"

Re: [PATCH 4/4] ASoc: kirkwood: add DT support

2013-07-26 Thread Russell King - ARM Linux
On Fri, Jul 26, 2013 at 11:09:13AM +0200, Jean-Francois Moine wrote: > The A510 documentation uses the names "DCO PLL" for the internal clock > and "AU_EXTCLK" for the external clock. So, what about "dcopll" and > "extclk"? Stop naming them according to their source. Their _consumer_ names not _s

Re: [PATCH 4/4] ASoc: kirkwood: add DT support

2013-07-26 Thread Jean-Francois Moine
On Fri, 26 Jul 2013 00:05:33 +0100 Russell King - ARM Linux wrote: > On Thu, Jul 25, 2013 at 08:19:05PM +0100, Mark Brown wrote: > > On Thu, Jul 25, 2013 at 11:14:59AM +0200, Jean-Francois Moine wrote: [snip] > > > - priv->clk = devm_clk_get(&pdev->dev, NULL); > > > + priv->clk = devm_clk

Re: [PATCH 4/4] ASoc: kirkwood: add DT support

2013-07-25 Thread Russell King - ARM Linux
On Thu, Jul 25, 2013 at 08:19:05PM +0100, Mark Brown wrote: > On Thu, Jul 25, 2013 at 11:14:59AM +0200, Jean-Francois Moine wrote: > > > + if (np) { > > + priv->burst = 128; /* might be 32 or 128 */ > > + } else if (data) { > > When you posted this before I queried how

Re: [PATCH 4/4] ASoc: kirkwood: add DT support

2013-07-25 Thread Mark Brown
On Thu, Jul 25, 2013 at 11:14:59AM +0200, Jean-Francois Moine wrote: > + if (np) { > + priv->burst = 128; /* might be 32 or 128 */ > + } else if (data) { When you posted this before I queried how and why the value might vary - I see the code is the same and I don'

[PATCH 4/4] ASoc: kirkwood: add DT support

2013-07-25 Thread Jean-Francois Moine
The kirkwood audio driver is used without DT in the Kirkwood machine. This patch adds a DT compatible definition for use in other Marvell machines as the Armada 88AP510 (Dove). Signed-off-by: Jean-Francois Moine --- .../devicetree/bindings/sound/kirkwood-i2s.txt | 29 ++ soun