Re: [RESEND PATCH 4/4] aio: use iovec array rather than the single one

2014-07-24 Thread Benjamin LaHaise
On Wed, Jul 23, 2014 at 06:03:54PM +0800, Gu Zheng wrote: > Previously, we only offer a single iovec to handle all the read/write cases, > so > the PREADV/PWRITEV request always need to alloc more iovec buffer when copying > user vectors. > If we use a tmp iovec array rather than the single one,

Re: [RESEND PATCH 4/4] aio: use iovec array rather than the single one

2014-07-24 Thread Benjamin LaHaise
On Wed, Jul 23, 2014 at 06:03:54PM +0800, Gu Zheng wrote: Previously, we only offer a single iovec to handle all the read/write cases, so the PREADV/PWRITEV request always need to alloc more iovec buffer when copying user vectors. If we use a tmp iovec array rather than the single one, some

Re: [RESEND PATCH 4/4] aio: use iovec array rather than the single one

2014-07-23 Thread Gu Zheng
Hi Jeff, On 07/23/2014 09:25 PM, Jeff Moyer wrote: > Gu Zheng writes: > >> Previously, we only offer a single iovec to handle all the read/write cases, >> so >> the PREADV/PWRITEV request always need to alloc more iovec buffer when >> copying >> user vectors. >> If we use a tmp iovec array

Re: [RESEND PATCH 4/4] aio: use iovec array rather than the single one

2014-07-23 Thread Jeff Moyer
Gu Zheng writes: > Previously, we only offer a single iovec to handle all the read/write cases, > so > the PREADV/PWRITEV request always need to alloc more iovec buffer when copying > user vectors. > If we use a tmp iovec array rather than the single one, some small > PREADV/PWRITEV >

Re: [RESEND PATCH 4/4] aio: use iovec array rather than the single one

2014-07-23 Thread Jeff Moyer
Gu Zheng guz.f...@cn.fujitsu.com writes: Previously, we only offer a single iovec to handle all the read/write cases, so the PREADV/PWRITEV request always need to alloc more iovec buffer when copying user vectors. If we use a tmp iovec array rather than the single one, some small

Re: [RESEND PATCH 4/4] aio: use iovec array rather than the single one

2014-07-23 Thread Gu Zheng
Hi Jeff, On 07/23/2014 09:25 PM, Jeff Moyer wrote: Gu Zheng guz.f...@cn.fujitsu.com writes: Previously, we only offer a single iovec to handle all the read/write cases, so the PREADV/PWRITEV request always need to alloc more iovec buffer when copying user vectors. If we use a tmp iovec

Re: [PATCH 4/4] aio: use iovec array rather than the single one

2014-07-22 Thread Gu Zheng
Hi Jeff, On 07/22/2014 11:20 PM, Jeff Moyer wrote: > Gu Zheng writes: > >> use an iovec array rather than the single one, so that we can avoid >> to alloc more iovecs buffer in small(< 8) PREADV/PWRITEV cases. > > I did some basic functional testing of this change and the change in > patch

Re: [PATCH 4/4] aio: use iovec array rather than the single one

2014-07-22 Thread Jeff Moyer
Gu Zheng writes: > use an iovec array rather than the single one, so that we can avoid > to alloc more iovecs buffer in small(< 8) PREADV/PWRITEV cases. I did some basic functional testing of this change and the change in patch 1/4. That testing included using aio-stress to drive queue depths

Re: [PATCH 4/4] aio: use iovec array rather than the single one

2014-07-22 Thread Jeff Moyer
Gu Zheng writes: > use an iovec array rather than the single one, so that we can avoid > to alloc more iovecs buffer in small(< 8) PREADV/PWRITEV cases. It would be helpful to know what motivated this change and how you tested it. Thanks, Jeff -- To unsubscribe from this list: send the line

Re: [PATCH 4/4] aio: use iovec array rather than the single one

2014-07-22 Thread Jeff Moyer
Gu Zheng guz.f...@cn.fujitsu.com writes: use an iovec array rather than the single one, so that we can avoid to alloc more iovecs buffer in small( 8) PREADV/PWRITEV cases. It would be helpful to know what motivated this change and how you tested it. Thanks, Jeff -- To unsubscribe from this

Re: [PATCH 4/4] aio: use iovec array rather than the single one

2014-07-22 Thread Jeff Moyer
Gu Zheng guz.f...@cn.fujitsu.com writes: use an iovec array rather than the single one, so that we can avoid to alloc more iovecs buffer in small( 8) PREADV/PWRITEV cases. I did some basic functional testing of this change and the change in patch 1/4. That testing included using aio-stress to

Re: [PATCH 4/4] aio: use iovec array rather than the single one

2014-07-22 Thread Gu Zheng
Hi Jeff, On 07/22/2014 11:20 PM, Jeff Moyer wrote: Gu Zheng guz.f...@cn.fujitsu.com writes: use an iovec array rather than the single one, so that we can avoid to alloc more iovecs buffer in small( 8) PREADV/PWRITEV cases. I did some basic functional testing of this change and the change