Re: [PATCH 4/4] arch/powerpc/44x/fsp2: wdt tcr update instead of whole rewrite

2017-05-26 Thread Michael Ellerman
Michael Ellerman writes: > Ivan Mikhaylov writes: >> >> From my point of view it's possible. I've checked docu and on idea >> it should be possible cause WP is only affecting watchdog ping time. > > The question is, is there any chance that leaving those

Re: [PATCH 4/4] arch/powerpc/44x/fsp2: wdt tcr update instead of whole rewrite

2017-05-26 Thread Michael Ellerman
Michael Ellerman writes: > Ivan Mikhaylov writes: >> >> From my point of view it's possible. I've checked docu and on idea >> it should be possible cause WP is only affecting watchdog ping time. > > The question is, is there any chance that leaving those bits set on > another platform will

Re: [PATCH 4/4] arch/powerpc/44x/fsp2: wdt tcr update instead of whole rewrite

2017-05-22 Thread Michael Ellerman
Ivan Mikhaylov writes: > > From my point of view it's possible. I've checked docu and on idea > it should be possible cause WP is only affecting watchdog ping time. The question is, is there any chance that leaving those bits set on another platform will cause a problem? ie. on

Re: [PATCH 4/4] arch/powerpc/44x/fsp2: wdt tcr update instead of whole rewrite

2017-05-22 Thread Michael Ellerman
Ivan Mikhaylov writes: > > From my point of view it's possible. I've checked docu and on idea > it should be possible cause WP is only affecting watchdog ping time. The question is, is there any chance that leaving those bits set on another platform will cause a problem? ie. on existing

Re: [PATCH 4/4] arch/powerpc/44x/fsp2: wdt tcr update instead of whole rewrite

2017-05-19 Thread Ivan Mikhaylov
Hi Michael, >> diff --git a/arch/powerpc/kernel/time.c b/arch/powerpc/kernel/time.c >> index 2b33cfa..f75e512 100644 >> --- a/arch/powerpc/kernel/time.c >> +++ b/arch/powerpc/kernel/time.c >> @@ -738,12 +738,28 @@ static int __init get_freq(char *name, int cells, >> unsigned long *val) >> >>

Re: [PATCH 4/4] arch/powerpc/44x/fsp2: wdt tcr update instead of whole rewrite

2017-05-19 Thread Ivan Mikhaylov
Hi Michael, >> diff --git a/arch/powerpc/kernel/time.c b/arch/powerpc/kernel/time.c >> index 2b33cfa..f75e512 100644 >> --- a/arch/powerpc/kernel/time.c >> +++ b/arch/powerpc/kernel/time.c >> @@ -738,12 +738,28 @@ static int __init get_freq(char *name, int cells, >> unsigned long *val) >> >>

Re: [PATCH 4/4] arch/powerpc/44x/fsp2: wdt tcr update instead of whole rewrite

2017-05-19 Thread Benjamin Herrenschmidt
On Mon, 2017-05-15 at 16:07 +0300, Ivan Mikhaylov wrote: > +#ifdef CONFIG_FSP2 > +   /* > +    * Prevent a kernel panic caused by unintentionally clearing TCR > +    * watchdog bits.  At this point in the kernel boot, the watchdog has > +    * already been enabled by u-boot.  The

Re: [PATCH 4/4] arch/powerpc/44x/fsp2: wdt tcr update instead of whole rewrite

2017-05-19 Thread Benjamin Herrenschmidt
On Mon, 2017-05-15 at 16:07 +0300, Ivan Mikhaylov wrote: > +#ifdef CONFIG_FSP2 > +   /* > +    * Prevent a kernel panic caused by unintentionally clearing TCR > +    * watchdog bits.  At this point in the kernel boot, the watchdog has > +    * already been enabled by u-boot.  The

Re: [PATCH 4/4] arch/powerpc/44x/fsp2: wdt tcr update instead of whole rewrite

2017-05-19 Thread Michael Ellerman
Hi Ivan, Ivan Mikhaylov writes: > Prevent a kernel panic caused by unintentionally clearing TCR > watchdog bits. At this point in the kernel boot, the watchdog has > already been enabled by u-boot. The original code's attempt to > write to the TCR register results in an

Re: [PATCH 4/4] arch/powerpc/44x/fsp2: wdt tcr update instead of whole rewrite

2017-05-19 Thread Michael Ellerman
Hi Ivan, Ivan Mikhaylov writes: > Prevent a kernel panic caused by unintentionally clearing TCR > watchdog bits. At this point in the kernel boot, the watchdog has > already been enabled by u-boot. The original code's attempt to > write to the TCR register results in an inadvertent clearing of

[PATCH 4/4] arch/powerpc/44x/fsp2: wdt tcr update instead of whole rewrite

2017-05-15 Thread Ivan Mikhaylov
Prevent a kernel panic caused by unintentionally clearing TCR watchdog bits. At this point in the kernel boot, the watchdog has already been enabled by u-boot. The original code's attempt to write to the TCR register results in an inadvertent clearing of the watchdog configuration bits, causing

[PATCH 4/4] arch/powerpc/44x/fsp2: wdt tcr update instead of whole rewrite

2017-05-15 Thread Ivan Mikhaylov
Prevent a kernel panic caused by unintentionally clearing TCR watchdog bits. At this point in the kernel boot, the watchdog has already been enabled by u-boot. The original code's attempt to write to the TCR register results in an inadvertent clearing of the watchdog configuration bits, causing