Re: [PATCH 4/4] checkpatch: replace magic value for TAB size

On Wed, 2019-05-08 at 17:32 +0200, Antonio Borneo wrote: > On Wed, May 8, 2019 at 4:52 PM Joe Perches wrote: > ... > > > In these cases the script will be probably modified and adapted, > > > so there is no need (at least for the moment) to expose this > > > setting on the script's command line.

Re: [PATCH 4/4] checkpatch: replace magic value for TAB size

On Wed, May 8, 2019 at 4:52 PM Joe Perches wrote: ... > > In these cases the script will be probably modified and adapted, > > so there is no need (at least for the moment) to expose this > > setting on the script's command line. > > Disagree. Probably getter to add a --tabsize= option now. Ok,

Re: [PATCH 4/4] checkpatch: replace magic value for TAB size

On Wed, 2019-05-08 at 14:27 +0200, Antonio Borneo wrote: > The size of 8 characters used for both TAB and indentation is > embedded as magic value allover the checkpatch script, and this > makes the script less readable. > > Replace the magic value 8 with the perl variable "$tabsize". > From the

[PATCH 4/4] checkpatch: replace magic value for TAB size

The size of 8 characters used for both TAB and indentation is embedded as magic value allover the checkpatch script, and this makes the script less readable. Replace the magic value 8 with the perl variable "$tabsize". >From the context of the code it's clear if it is used for indentation or