Re: [PATCH 4/4] leds-lp5523: minor code style fixes

2012-08-21 Thread Bryan Wu
On Tue, Aug 21, 2012 at 5:04 PM, Kim, Milo wrote: > (a) use LP5523_ENABLE rather than magic number 0x40 > (b) use min_t() in lp5523_mux_parse() > (c) skip while loop and just return if invalid command > Thanks for this cleanup. I will merge it later. -Bryan > Signed-off-by: Milo(Woogyom) Kim

[PATCH 4/4] leds-lp5523: minor code style fixes

2012-08-21 Thread Kim, Milo
(a) use LP5523_ENABLE rather than magic number 0x40 (b) use min_t() in lp5523_mux_parse() (c) skip while loop and just return if invalid command Signed-off-by: Milo(Woogyom) Kim --- drivers/leds/leds-lp5523.c | 15 +++ 1 files changed, 7 insertions(+), 8 deletions(-) diff --git

Re: [PATCH 4/4] leds-lp5523: minor code style fixes

2012-08-21 Thread Bryan Wu
On Tue, Aug 21, 2012 at 5:04 PM, Kim, Milo milo@ti.com wrote: (a) use LP5523_ENABLE rather than magic number 0x40 (b) use min_t() in lp5523_mux_parse() (c) skip while loop and just return if invalid command Thanks for this cleanup. I will merge it later. -Bryan Signed-off-by:

[PATCH 4/4] leds-lp5523: minor code style fixes

2012-08-21 Thread Kim, Milo
(a) use LP5523_ENABLE rather than magic number 0x40 (b) use min_t() in lp5523_mux_parse() (c) skip while loop and just return if invalid command Signed-off-by: Milo(Woogyom) Kim milo@ti.com --- drivers/leds/leds-lp5523.c | 15 +++ 1 files changed, 7 insertions(+), 8