Re: [PATCH 4/4] mic: vop: copy data to kernel space then write to io memory

2020-09-25 Thread kernel test robot
Hi Sherry, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on char-misc/char-misc-testing] [also build test WARNING on soc/for-next linus/master v5.9-rc6 next-20200924] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

Re: [PATCH 4/4] mic: vop: copy data to kernel space then write to io memory

2020-09-25 Thread kernel test robot
Hi Sherry, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on char-misc/char-misc-testing] [also build test WARNING on soc/for-next linus/master v5.9-rc6 next-20200924] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

RE: [PATCH 4/4] mic: vop: copy data to kernel space then write to io memory

2020-09-25 Thread Sherry Sun
Hi Arnd, > Subject: Re: [PATCH 4/4] mic: vop: copy data to kernel space then write to io > memory > > On Fri, Sep 25, 2020 at 9:22 AM Sherry Sun wrote: > > > > > @@ -655,12 +656,15 @@ static int vop_virtio_copy_from_user(struct > vop_vdev *vdev, void __user *ubuf, > > * We are copying

Re: [PATCH 4/4] mic: vop: copy data to kernel space then write to io memory

2020-09-25 Thread Arnd Bergmann
On Fri, Sep 25, 2020 at 9:22 AM Sherry Sun wrote: > > @@ -655,12 +656,15 @@ static int vop_virtio_copy_from_user(struct vop_vdev > *vdev, void __user *ubuf, > * We are copying to IO below and should ideally use something > * like copy_from_user_toio(..) if it existed. >

[PATCH 4/4] mic: vop: copy data to kernel space then write to io memory

2020-09-25 Thread Sherry Sun
Read and write io memory should address align on ARCH ARM. Change to use memcpy_toio to avoid kernel panic caused by the address un-align issue. Signed-off-by: Sherry Sun Signed-off-by: Joakim Zhang --- drivers/misc/mic/vop/vop_vringh.c | 6 +- 1 file changed, 5 insertions(+), 1