Re: [PATCH 4/4] mm, notifier: Catch sleeping/blocking for !blockable

2019-08-22 Thread Daniel Vetter
On Thu, Aug 22, 2019 at 4:24 PM Jason Gunthorpe wrote: > > On Thu, Aug 22, 2019 at 10:42:39AM +0200, Daniel Vetter wrote: > > > > RDMA has a mutex: > > > > > > ib_umem_notifier_invalidate_range_end > > > rbt_ib_umem_for_each_in_range > > >invalidate_range_start_trampoline > > >

Re: [PATCH 4/4] mm, notifier: Catch sleeping/blocking for !blockable

2019-08-22 Thread Daniel Vetter
On Thu, Aug 22, 2019 at 10:16 AM Jason Gunthorpe wrote: > > On Wed, Aug 21, 2019 at 05:41:51PM +0200, Daniel Vetter wrote: > > > > Hm, I thought the page table locks we're holding there already prevent any > > > sleeping, so would be redundant? But reading through code I think that's > > > not

Re: [PATCH 4/4] mm, notifier: Catch sleeping/blocking for !blockable

2019-08-21 Thread Jason Gunthorpe
On Wed, Aug 21, 2019 at 05:41:51PM +0200, Daniel Vetter wrote: > > Hm, I thought the page table locks we're holding there already prevent any > > sleeping, so would be redundant? But reading through code I think that's > > not guaranteed, so yeah makes sense to add it for invalidate_range_end > >

Re: [PATCH 4/4] mm, notifier: Catch sleeping/blocking for !blockable

2019-08-20 Thread Jason Gunthorpe
On Tue, Aug 20, 2019 at 10:19:02AM +0200, Daniel Vetter wrote: > We need to make sure implementations don't cheat and don't have a > possible schedule/blocking point deeply burried where review can't > catch it. > > I'm not sure whether this is the best way to make sure all the > might_sleep()