Re: [PATCH 4/4] mtd: nand: omap2: Add data correction support

2012-10-11 Thread Tony Lindgren
* Ivan Djelic [121011 01:23]: > > I don't know which way is better for the OMAP community: > 1. Unifying ECC modes = loosing the constant polynomial benefits, but gaining > RBL compat and simplifying code > 2. Keeping separate ECC modes = code bloat > > Tony, do you have an opinion on this ? W

RE: [PATCH 4/4] mtd: nand: omap2: Add data correction support

2012-10-11 Thread Philip, Avinash
On Thu, Oct 11, 2012 at 13:51:49, Ivan Djelic wrote: > On Thu, Oct 11, 2012 at 06:27:13AM +0100, Philip, Avinash wrote: > (...) > > > Another simple strategy could use the fact that you add a 14th zero byte > > > to > > > the 13 BCH bytes for RBL compatibility: > > > > RBL compatibility (14th byt

Re: [PATCH 4/4] mtd: nand: omap2: Add data correction support

2012-10-11 Thread Ivan Djelic
On Thu, Oct 11, 2012 at 06:27:13AM +0100, Philip, Avinash wrote: (...) > > Another simple strategy could use the fact that you add a 14th zero byte to > > the 13 BCH bytes for RBL compatibility: > > RBL compatibility (14th byte) is applicable only for BCH8 ecc scheme. > > So I am planning adding

RE: [PATCH 4/4] mtd: nand: omap2: Add data correction support

2012-10-10 Thread Philip, Avinash
On Wed, Oct 10, 2012 at 22:38:06, Ivan Djelic wrote: > On Tue, Oct 09, 2012 at 01:36:50PM +0100, Philip, Avinash wrote: > (...) > > > There are at least 2 potential problems when reading an erased page with > > > bitflips: > > > > > > 1. bitflip in data area and no bitflip in spare area (all 0xff

Re: [PATCH 4/4] mtd: nand: omap2: Add data correction support

2012-10-10 Thread Ivan Djelic
On Tue, Oct 09, 2012 at 01:36:50PM +0100, Philip, Avinash wrote: (...) > > There are at least 2 potential problems when reading an erased page with > > bitflips: > > > > 1. bitflip in data area and no bitflip in spare area (all 0xff) > > Your code will not perform any ECC correction. > > UBIFS do

RE: [PATCH 4/4] mtd: nand: omap2: Add data correction support

2012-10-09 Thread Philip, Avinash
On Fri, Oct 05, 2012 at 19:53:38, Ivan Djelic wrote: > On Fri, Oct 05, 2012 at 09:51:50AM +0100, Philip, Avinash wrote: > > On Thu, Oct 04, 2012 at 15:51:03, Philip, Avinash wrote: > > > On Thu, Oct 04, 2012 at 00:50:45, Ivan Djelic wrote: > > > > On Wed, Oct 03, 2012 at 03:29:49PM +0100, Philip, A

Re: [PATCH 4/4] mtd: nand: omap2: Add data correction support

2012-10-05 Thread Ivan Djelic
On Fri, Oct 05, 2012 at 09:51:50AM +0100, Philip, Avinash wrote: > On Thu, Oct 04, 2012 at 15:51:03, Philip, Avinash wrote: > > On Thu, Oct 04, 2012 at 00:50:45, Ivan Djelic wrote: > > > On Wed, Oct 03, 2012 at 03:29:49PM +0100, Philip, Avinash wrote: > > > > ELM module can be used for error correc

RE: [PATCH 4/4] mtd: nand: omap2: Add data correction support

2012-10-05 Thread Philip, Avinash
On Thu, Oct 04, 2012 at 15:51:03, Philip, Avinash wrote: > On Thu, Oct 04, 2012 at 00:50:45, Ivan Djelic wrote: > > On Wed, Oct 03, 2012 at 03:29:49PM +0100, Philip, Avinash wrote: > > > ELM module can be used for error correction of BCH 4 & 8 bit. Also > > > support read & write page in one shot b

RE: [PATCH 4/4] mtd: nand: omap2: Add data correction support

2012-10-04 Thread Philip, Avinash
On Thu, Oct 04, 2012 at 00:50:45, Ivan Djelic wrote: > On Wed, Oct 03, 2012 at 03:29:49PM +0100, Philip, Avinash wrote: > > ELM module can be used for error correction of BCH 4 & 8 bit. Also > > support read & write page in one shot by adding custom read_page & > > write_page methods. This helps in

Re: [PATCH 4/4] mtd: nand: omap2: Add data correction support

2012-10-03 Thread Ivan Djelic
On Wed, Oct 03, 2012 at 03:29:49PM +0100, Philip, Avinash wrote: > ELM module can be used for error correction of BCH 4 & 8 bit. Also > support read & write page in one shot by adding custom read_page & > write_page methods. This helps in optimizing code. > > New structure member "is_elm_used" is

[PATCH 4/4] mtd: nand: omap2: Add data correction support

2012-10-03 Thread Philip, Avinash
ELM module can be used for error correction of BCH 4 & 8 bit. Also support read & write page in one shot by adding custom read_page & write_page methods. This helps in optimizing code. New structure member "is_elm_used" is added to know the status of whether the ELM module is used for error correc