Re: [PATCH 4/4] net: dsa: mv88e6xxx: Support serdes ports on MV88E6123/6131

2020-10-27 Thread Andrew Lunn
On Tue, Oct 27, 2020 at 08:56:09PM +, Chris Packham wrote: > > On 24/10/20 11:42 am, Andrew Lunn wrote: > >> +int mv88e6123_serdes_get_regs_len(struct mv88e6xxx_chip *chip, int port) > >> +{ > >> + if (mv88e6xxx_serdes_get_lane(chip, port) == 0) > >> + return 0; > >> + > >> +

Re: [PATCH 4/4] net: dsa: mv88e6xxx: Support serdes ports on MV88E6123/6131

2020-10-27 Thread Chris Packham
On 24/10/20 11:42 am, Andrew Lunn wrote: >> +int mv88e6123_serdes_get_regs_len(struct mv88e6xxx_chip *chip, int port) >> +{ >> +if (mv88e6xxx_serdes_get_lane(chip, port) == 0) >> +return 0; >> + >> +return 26 * sizeof(u16); >> +} > Hi Chris > > Where did 26 come from? In the

Re: [PATCH 4/4] net: dsa: mv88e6xxx: Support serdes ports on MV88E6123/6131

2020-10-23 Thread Andrew Lunn
> +int mv88e6123_serdes_get_regs_len(struct mv88e6xxx_chip *chip, int port) > +{ > + if (mv88e6xxx_serdes_get_lane(chip, port) == 0) > + return 0; > + > + return 26 * sizeof(u16); > +} Hi Chris Where did 26 come from? Andrew

[PATCH 4/4] net: dsa: mv88e6xxx: Support serdes ports on MV88E6123/6131

2020-10-21 Thread Chris Packham
Implement serdes_power, serdes_get_lane and serdes_pcs_get_state ops for the MV88E6123 so that the ports without a built-in PHY supported as serdes ports and directly connected to other network interfaces or to SFPs. Also implement serdes_get_regs_len and serdes_get_regs to aid future debugging.