Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-06-12 Thread Rik van Riel
On 05/18/2015 10:30 PM, Mike Galbraith wrote: > On Mon, 2015-05-18 at 10:52 -0400, Rik van Riel wrote: > >> For real time KVM, it is desirable to run the VCPU threads on >> isolated CPUs as real time tasks. >> >> Meanwhile, the emulator threads can run as normal tasks anywhere >> on the system.

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-06-12 Thread Rik van Riel
On 05/18/2015 10:30 PM, Mike Galbraith wrote: On Mon, 2015-05-18 at 10:52 -0400, Rik van Riel wrote: For real time KVM, it is desirable to run the VCPU threads on isolated CPUs as real time tasks. Meanwhile, the emulator threads can run as normal tasks anywhere on the system. This means

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-05-22 Thread Mike Galbraith
On Fri, 2015-05-22 at 16:39 +0200, Frederic Weisbecker wrote: > On Thu, May 21, 2015 at 08:59:38PM +0200, Mike Galbraith wrote: > > I think it's a mistake to make any rash assumption and/or mandate that > > the user WILL use nohz_full CPUs immediately, or even at all for that > > matter.

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-05-22 Thread Frederic Weisbecker
On Thu, May 21, 2015 at 08:59:38PM +0200, Mike Galbraith wrote: > I think it's a mistake to make any rash assumption and/or mandate that > the user WILL use nohz_full CPUs immediately, or even at all for that > matter. nohz_full currently is nothing but a CPU attribute, period, > nothing more,

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-05-22 Thread Frederic Weisbecker
On Thu, May 21, 2015 at 08:59:38PM +0200, Mike Galbraith wrote: I think it's a mistake to make any rash assumption and/or mandate that the user WILL use nohz_full CPUs immediately, or even at all for that matter. nohz_full currently is nothing but a CPU attribute, period, nothing more,

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-05-22 Thread Mike Galbraith
On Fri, 2015-05-22 at 16:39 +0200, Frederic Weisbecker wrote: On Thu, May 21, 2015 at 08:59:38PM +0200, Mike Galbraith wrote: I think it's a mistake to make any rash assumption and/or mandate that the user WILL use nohz_full CPUs immediately, or even at all for that matter. nohz_full

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-05-21 Thread Mike Galbraith
On Thu, 2015-05-21 at 15:06 +0200, Frederic Weisbecker wrote: > On Thu, May 21, 2015 at 05:57:59AM -0700, Paul E. McKenney wrote: > > On Thu, May 21, 2015 at 05:42:46PM +0530, Afzal Mohammed wrote: > > > Hi, > > > > > > On Wed, May 20, 2015 at 02:00:26PM -0700, Paul E. McKenney wrote: > > > > >

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-05-21 Thread Frederic Weisbecker
On Thu, May 21, 2015 at 07:14:09AM -0700, Paul E. McKenney wrote: > On Thu, May 21, 2015 at 06:59:05PM +0530, Afzal Mohammed wrote: > > Hi, > > > > On Thu, May 21, 2015 at 03:06:23PM +0200, Frederic Weisbecker wrote: > > > On Thu, May 21, 2015 at 05:57:59AM -0700, Paul E. McKenney wrote: > > > >

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-05-21 Thread Paul E. McKenney
On Thu, May 21, 2015 at 06:59:05PM +0530, Afzal Mohammed wrote: > Hi, > > On Thu, May 21, 2015 at 03:06:23PM +0200, Frederic Weisbecker wrote: > > On Thu, May 21, 2015 at 05:57:59AM -0700, Paul E. McKenney wrote: > > > > Indeed, NO_HZ_FULL is special purpose. You normally would select > > >

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-05-21 Thread Afzal Mohammed
Hi, On Thu, May 21, 2015 at 03:06:23PM +0200, Frederic Weisbecker wrote: > On Thu, May 21, 2015 at 05:57:59AM -0700, Paul E. McKenney wrote: > > Indeed, NO_HZ_FULL is special purpose. You normally would select > > NO_HZ_FULL_ALL only on a system intended for heavy compute without > >

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-05-21 Thread Paul E. McKenney
On Thu, May 21, 2015 at 03:06:23PM +0200, Frederic Weisbecker wrote: > On Thu, May 21, 2015 at 05:57:59AM -0700, Paul E. McKenney wrote: > > On Thu, May 21, 2015 at 05:42:46PM +0530, Afzal Mohammed wrote: > > > Hi, > > > > > > On Wed, May 20, 2015 at 02:00:26PM -0700, Paul E. McKenney wrote: > >

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-05-21 Thread Frederic Weisbecker
On Thu, May 21, 2015 at 05:57:59AM -0700, Paul E. McKenney wrote: > On Thu, May 21, 2015 at 05:42:46PM +0530, Afzal Mohammed wrote: > > Hi, > > > > On Wed, May 20, 2015 at 02:00:26PM -0700, Paul E. McKenney wrote: > > > > > > > Given that kernel initiated association to isolcpus, a user turning

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-05-21 Thread Paul E. McKenney
On Thu, May 21, 2015 at 05:42:46PM +0530, Afzal Mohammed wrote: > Hi, > > On Wed, May 20, 2015 at 02:00:26PM -0700, Paul E. McKenney wrote: > > > > > Given that kernel initiated association to isolcpus, a user turning > > > > NO_HZ_FULL_ALL on had better not have much generic load to manage. If

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-05-21 Thread Afzal Mohammed
Hi, On Wed, May 20, 2015 at 02:00:26PM -0700, Paul E. McKenney wrote: > > > Given that kernel initiated association to isolcpus, a user turning > > > NO_HZ_FULL_ALL on had better not have much generic load to manage. If > > > > On a quad-core desktop system with NO_HZ_FULL_ALL, hackbench took

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-05-21 Thread Mike Galbraith
On Thu, 2015-05-21 at 15:06 +0200, Frederic Weisbecker wrote: On Thu, May 21, 2015 at 05:57:59AM -0700, Paul E. McKenney wrote: On Thu, May 21, 2015 at 05:42:46PM +0530, Afzal Mohammed wrote: Hi, On Wed, May 20, 2015 at 02:00:26PM -0700, Paul E. McKenney wrote: Given that

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-05-21 Thread Afzal Mohammed
Hi, On Wed, May 20, 2015 at 02:00:26PM -0700, Paul E. McKenney wrote: Given that kernel initiated association to isolcpus, a user turning NO_HZ_FULL_ALL on had better not have much generic load to manage. If On a quad-core desktop system with NO_HZ_FULL_ALL, hackbench took 3x time

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-05-21 Thread Paul E. McKenney
On Thu, May 21, 2015 at 05:42:46PM +0530, Afzal Mohammed wrote: Hi, On Wed, May 20, 2015 at 02:00:26PM -0700, Paul E. McKenney wrote: Given that kernel initiated association to isolcpus, a user turning NO_HZ_FULL_ALL on had better not have much generic load to manage. If On a

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-05-21 Thread Frederic Weisbecker
On Thu, May 21, 2015 at 05:57:59AM -0700, Paul E. McKenney wrote: On Thu, May 21, 2015 at 05:42:46PM +0530, Afzal Mohammed wrote: Hi, On Wed, May 20, 2015 at 02:00:26PM -0700, Paul E. McKenney wrote: Given that kernel initiated association to isolcpus, a user turning

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-05-21 Thread Frederic Weisbecker
On Thu, May 21, 2015 at 07:14:09AM -0700, Paul E. McKenney wrote: On Thu, May 21, 2015 at 06:59:05PM +0530, Afzal Mohammed wrote: Hi, On Thu, May 21, 2015 at 03:06:23PM +0200, Frederic Weisbecker wrote: On Thu, May 21, 2015 at 05:57:59AM -0700, Paul E. McKenney wrote: Indeed,

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-05-21 Thread Paul E. McKenney
On Thu, May 21, 2015 at 03:06:23PM +0200, Frederic Weisbecker wrote: On Thu, May 21, 2015 at 05:57:59AM -0700, Paul E. McKenney wrote: On Thu, May 21, 2015 at 05:42:46PM +0530, Afzal Mohammed wrote: Hi, On Wed, May 20, 2015 at 02:00:26PM -0700, Paul E. McKenney wrote: Given

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-05-21 Thread Afzal Mohammed
Hi, On Thu, May 21, 2015 at 03:06:23PM +0200, Frederic Weisbecker wrote: On Thu, May 21, 2015 at 05:57:59AM -0700, Paul E. McKenney wrote: Indeed, NO_HZ_FULL is special purpose. You normally would select NO_HZ_FULL_ALL only on a system intended for heavy compute without normal-workload

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-05-21 Thread Paul E. McKenney
On Thu, May 21, 2015 at 06:59:05PM +0530, Afzal Mohammed wrote: Hi, On Thu, May 21, 2015 at 03:06:23PM +0200, Frederic Weisbecker wrote: On Thu, May 21, 2015 at 05:57:59AM -0700, Paul E. McKenney wrote: Indeed, NO_HZ_FULL is special purpose. You normally would select NO_HZ_FULL_ALL

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-05-20 Thread Paul E. McKenney
On Thu, May 21, 2015 at 02:08:09AM +0530, Afzal Mohammed wrote: > Hi, > > On Sun, May 17, 2015 at 07:30:50AM +0200, Mike Galbraith wrote: > > > Yeah, tying nohz_full set to isolcpus set up an initial condition that > > you have to tear down with cpusets if you want those cpus returned to > > the

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-05-20 Thread Afzal Mohammed
Hi, On Sun, May 17, 2015 at 07:30:50AM +0200, Mike Galbraith wrote: > Yeah, tying nohz_full set to isolcpus set up an initial condition that > you have to tear down with cpusets if you want those cpus returned to > the general purpose pool. I had considered the kernel setting initial > state to

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-05-20 Thread Paul E. McKenney
On Thu, May 21, 2015 at 02:08:09AM +0530, Afzal Mohammed wrote: Hi, On Sun, May 17, 2015 at 07:30:50AM +0200, Mike Galbraith wrote: Yeah, tying nohz_full set to isolcpus set up an initial condition that you have to tear down with cpusets if you want those cpus returned to the general

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-05-20 Thread Afzal Mohammed
Hi, On Sun, May 17, 2015 at 07:30:50AM +0200, Mike Galbraith wrote: Yeah, tying nohz_full set to isolcpus set up an initial condition that you have to tear down with cpusets if you want those cpus returned to the general purpose pool. I had considered the kernel setting initial state to be

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-05-18 Thread Mike Galbraith
On Mon, 2015-05-18 at 10:52 -0400, Rik van Riel wrote: > For real time KVM, it is desirable to run the VCPU threads on > isolated CPUs as real time tasks. > > Meanwhile, the emulator threads can run as normal tasks anywhere > on the system. > > This means the /machine cpuset, which all guests

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-05-18 Thread Rik van Riel
On 05/18/2015 10:22 AM, Mike Galbraith wrote: > On Mon, 2015-05-18 at 10:07 -0400, Rik van Riel wrote: >> On 05/17/2015 11:29 PM, Mike Galbraith wrote: >>> On Sun, 2015-05-17 at 22:17 -0400, Rik van Riel wrote: On 05/17/2015 01:30 AM, Mike Galbraith wrote: > Given that kernel

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-05-18 Thread Mike Galbraith
On Mon, 2015-05-18 at 10:07 -0400, Rik van Riel wrote: > On 05/17/2015 11:29 PM, Mike Galbraith wrote: > > On Sun, 2015-05-17 at 22:17 -0400, Rik van Riel wrote: > >> On 05/17/2015 01:30 AM, Mike Galbraith wrote: > >> > >>> Given that kernel initiated association to isolcpus, a user turning > >>>

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-05-18 Thread Rik van Riel
On 05/17/2015 11:29 PM, Mike Galbraith wrote: > On Sun, 2015-05-17 at 22:17 -0400, Rik van Riel wrote: >> On 05/17/2015 01:30 AM, Mike Galbraith wrote: >> >>> Given that kernel initiated association to isolcpus, a user turning >>> NO_HZ_FULL_ALL on had better not have much generic load to manage.

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-05-18 Thread Mike Galbraith
On Mon, 2015-05-18 at 10:07 -0400, Rik van Riel wrote: On 05/17/2015 11:29 PM, Mike Galbraith wrote: On Sun, 2015-05-17 at 22:17 -0400, Rik van Riel wrote: On 05/17/2015 01:30 AM, Mike Galbraith wrote: Given that kernel initiated association to isolcpus, a user turning NO_HZ_FULL_ALL on

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-05-18 Thread Rik van Riel
On 05/18/2015 10:22 AM, Mike Galbraith wrote: On Mon, 2015-05-18 at 10:07 -0400, Rik van Riel wrote: On 05/17/2015 11:29 PM, Mike Galbraith wrote: On Sun, 2015-05-17 at 22:17 -0400, Rik van Riel wrote: On 05/17/2015 01:30 AM, Mike Galbraith wrote: Given that kernel initiated association to

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-05-18 Thread Rik van Riel
On 05/17/2015 11:29 PM, Mike Galbraith wrote: On Sun, 2015-05-17 at 22:17 -0400, Rik van Riel wrote: On 05/17/2015 01:30 AM, Mike Galbraith wrote: Given that kernel initiated association to isolcpus, a user turning NO_HZ_FULL_ALL on had better not have much generic load to manage. If he/she

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-05-18 Thread Mike Galbraith
On Mon, 2015-05-18 at 10:52 -0400, Rik van Riel wrote: For real time KVM, it is desirable to run the VCPU threads on isolated CPUs as real time tasks. Meanwhile, the emulator threads can run as normal tasks anywhere on the system. This means the /machine cpuset, which all guests live

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-05-17 Thread Mike Galbraith
On Sun, 2015-05-17 at 22:17 -0400, Rik van Riel wrote: > On 05/17/2015 01:30 AM, Mike Galbraith wrote: > > > Given that kernel initiated association to isolcpus, a user turning > > NO_HZ_FULL_ALL on had better not have much generic load to manage. If > > he/she does not have CPUSETS enabled, or

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-05-17 Thread Rik van Riel
On 05/17/2015 01:30 AM, Mike Galbraith wrote: > Given that kernel initiated association to isolcpus, a user turning > NO_HZ_FULL_ALL on had better not have much generic load to manage. If > he/she does not have CPUSETS enabled, or should Rik's patch rendering > isolcpus immutable be merged, My

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-05-17 Thread Mike Galbraith
On Sun, 2015-05-17 at 22:17 -0400, Rik van Riel wrote: On 05/17/2015 01:30 AM, Mike Galbraith wrote: Given that kernel initiated association to isolcpus, a user turning NO_HZ_FULL_ALL on had better not have much generic load to manage. If he/she does not have CPUSETS enabled, or should

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-05-17 Thread Rik van Riel
On 05/17/2015 01:30 AM, Mike Galbraith wrote: Given that kernel initiated association to isolcpus, a user turning NO_HZ_FULL_ALL on had better not have much generic load to manage. If he/she does not have CPUSETS enabled, or should Rik's patch rendering isolcpus immutable be merged, My

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-05-16 Thread Mike Galbraith
On Sat, 2015-05-16 at 15:39 -0400, Sasha Levin wrote: > On 05/06/2015 12:04 PM, Frederic Weisbecker wrote: > > From: Chris Metcalf > > > > nohz_full is only useful with isolcpus also set, since otherwise the > > scheduler has to run periodically to try to determine whether to steal > > work from

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-05-16 Thread Sasha Levin
On 05/06/2015 12:04 PM, Frederic Weisbecker wrote: > From: Chris Metcalf > > nohz_full is only useful with isolcpus also set, since otherwise the > scheduler has to run periodically to try to determine whether to steal > work from other cores. > > Accordingly, when booting with nohz_full=xxx on

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-05-16 Thread Sasha Levin
On 05/06/2015 12:04 PM, Frederic Weisbecker wrote: From: Chris Metcalf cmetc...@ezchip.com nohz_full is only useful with isolcpus also set, since otherwise the scheduler has to run periodically to try to determine whether to steal work from other cores. Accordingly, when booting with

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-05-16 Thread Mike Galbraith
On Sat, 2015-05-16 at 15:39 -0400, Sasha Levin wrote: On 05/06/2015 12:04 PM, Frederic Weisbecker wrote: From: Chris Metcalf cmetc...@ezchip.com nohz_full is only useful with isolcpus also set, since otherwise the scheduler has to run periodically to try to determine whether to steal

[PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-05-06 Thread Frederic Weisbecker
From: Chris Metcalf nohz_full is only useful with isolcpus also set, since otherwise the scheduler has to run periodically to try to determine whether to steal work from other cores. Accordingly, when booting with nohz_full=xxx on the command line, we should act as if isolcpus=xxx was also set,

[PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-05-06 Thread Frederic Weisbecker
From: Chris Metcalf cmetc...@ezchip.com nohz_full is only useful with isolcpus also set, since otherwise the scheduler has to run periodically to try to determine whether to steal work from other cores. Accordingly, when booting with nohz_full=xxx on the command line, we should act as if

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-04-25 Thread Gene Heskett
On Saturday 25 April 2015 19:13:10 Frederic Weisbecker wrote: > On Fri, Apr 24, 2015 at 04:07:52PM -0400, Gene Heskett wrote: > > On Friday 24 April 2015 11:58:31 Frederic Weisbecker wrote: > > > From: Chris Metcalf > > > > > > nohz_full is only useful with isolcpus also set, since otherwise > >

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-04-25 Thread Frederic Weisbecker
On Fri, Apr 24, 2015 at 04:07:52PM -0400, Gene Heskett wrote: > On Friday 24 April 2015 11:58:31 Frederic Weisbecker wrote: > > From: Chris Metcalf > > > > nohz_full is only useful with isolcpus also set, since otherwise the > > scheduler has to run periodically to try to determine whether to

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-04-25 Thread Gene Heskett
On Saturday 25 April 2015 19:13:10 Frederic Weisbecker wrote: On Fri, Apr 24, 2015 at 04:07:52PM -0400, Gene Heskett wrote: On Friday 24 April 2015 11:58:31 Frederic Weisbecker wrote: From: Chris Metcalf cmetc...@ezchip.com nohz_full is only useful with isolcpus also set, since

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-04-25 Thread Frederic Weisbecker
On Fri, Apr 24, 2015 at 04:07:52PM -0400, Gene Heskett wrote: On Friday 24 April 2015 11:58:31 Frederic Weisbecker wrote: From: Chris Metcalf cmetc...@ezchip.com nohz_full is only useful with isolcpus also set, since otherwise the scheduler has to run periodically to try to determine

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-04-24 Thread Gene Heskett
On Friday 24 April 2015 11:58:31 Frederic Weisbecker wrote: > From: Chris Metcalf > > nohz_full is only useful with isolcpus also set, since otherwise the > scheduler has to run periodically to try to determine whether to steal > work from other cores. > > Accordingly, when booting with

[PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-04-24 Thread Frederic Weisbecker
From: Chris Metcalf nohz_full is only useful with isolcpus also set, since otherwise the scheduler has to run periodically to try to determine whether to steal work from other cores. Accordingly, when booting with nohz_full=xxx on the command line, we should act as if isolcpus=xxx was also set,

[PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-04-24 Thread Frederic Weisbecker
From: Chris Metcalf cmetc...@ezchip.com nohz_full is only useful with isolcpus also set, since otherwise the scheduler has to run periodically to try to determine whether to steal work from other cores. Accordingly, when booting with nohz_full=xxx on the command line, we should act as if

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-04-24 Thread Gene Heskett
On Friday 24 April 2015 11:58:31 Frederic Weisbecker wrote: From: Chris Metcalf cmetc...@ezchip.com nohz_full is only useful with isolcpus also set, since otherwise the scheduler has to run periodically to try to determine whether to steal work from other cores. Accordingly, when booting

[PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-04-21 Thread Frederic Weisbecker
From: Chris Metcalf nohz_full is only useful with isolcpus also set, since otherwise the scheduler has to run periodically to try to determine whether to steal work from other cores. Accordingly, when booting with nohz_full=xxx on the command line, we should act as if isolcpus=xxx was also set,

[PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-04-21 Thread Frederic Weisbecker
From: Chris Metcalf cmetc...@ezchip.com nohz_full is only useful with isolcpus also set, since otherwise the scheduler has to run periodically to try to determine whether to steal work from other cores. Accordingly, when booting with nohz_full=xxx on the command line, we should act as if