Re: [PATCH 4/4] staging: ste_rmi4: Suppress 'ignoring return value of ‘regulator_enable()' warning

2013-05-14 Thread Greg Kroah-Hartman
On Tue, May 14, 2013 at 11:46:31AM +0100, Lee Jones wrote: > Hi Greg, > > > drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c: > > In function ‘synaptics_rmi4_resume’: > > drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c:1090:18: > > warning: ignoring return value of ‘regulator_enable’,

Re: [PATCH 4/4] staging: ste_rmi4: Suppress 'ignoring return value of ‘regulator_enable()' warning

2013-05-14 Thread Lee Jones
Hi Greg, > drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c: > In function ‘synaptics_rmi4_resume’: > drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c:1090:18: > warning: ignoring return value of ‘regulator_enable’, declared > with attribute warn_unused_result [-Wunused-result >

Re: [PATCH 4/4] staging: ste_rmi4: Suppress 'ignoring return value of ‘regulator_enable()' warning

2013-05-14 Thread Lee Jones
Hi Greg, drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c: In function ‘synaptics_rmi4_resume’: drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c:1090:18: warning: ignoring return value of ‘regulator_enable’, declared with attribute warn_unused_result [-Wunused-result Cc:

Re: [PATCH 4/4] staging: ste_rmi4: Suppress 'ignoring return value of ‘regulator_enable()' warning

2013-05-14 Thread Greg Kroah-Hartman
On Tue, May 14, 2013 at 11:46:31AM +0100, Lee Jones wrote: Hi Greg, drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c: In function ‘synaptics_rmi4_resume’: drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c:1090:18: warning: ignoring return value of ‘regulator_enable’, declared

Re: [PATCH 4/4] staging: ste_rmi4: Suppress 'ignoring return value of ‘regulator_enable()' warning

2013-05-06 Thread Dan Carpenter
On Mon, May 06, 2013 at 12:21:39PM +0530, Srinidhi Kasagar wrote: > > > > - regulator_enable(rmi4_data->regulator); > > > > + retval = regulator_enable(rmi4_data->regulator); > > > > + if (retval < 0) > > > > + return retval; > > > Does it make sense to add a

Re: [PATCH 4/4] staging: ste_rmi4: Suppress 'ignoring return value of ‘regulator_enable()' warning

2013-05-06 Thread Srinidhi Kasagar
On Sun, May 05, 2013 at 16:18:55 +0200, Dan Carpenter wrote: > On Fri, May 03, 2013 at 12:37:14PM +0530, Srinidhi Kasagar wrote: > > On Thu, May 02, 2013 at 17:48:10 +0200, Lee Jones wrote: > > > drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c: > > > In function ‘synaptics_rmi4_resume’: > >

Re: [PATCH 4/4] staging: ste_rmi4: Suppress 'ignoring return value of ‘regulator_enable()' warning

2013-05-06 Thread Srinidhi Kasagar
On Sun, May 05, 2013 at 16:18:55 +0200, Dan Carpenter wrote: On Fri, May 03, 2013 at 12:37:14PM +0530, Srinidhi Kasagar wrote: On Thu, May 02, 2013 at 17:48:10 +0200, Lee Jones wrote: drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c: In function ‘synaptics_rmi4_resume’:

Re: [PATCH 4/4] staging: ste_rmi4: Suppress 'ignoring return value of ‘regulator_enable()' warning

2013-05-06 Thread Dan Carpenter
On Mon, May 06, 2013 at 12:21:39PM +0530, Srinidhi Kasagar wrote: - regulator_enable(rmi4_data-regulator); + retval = regulator_enable(rmi4_data-regulator); + if (retval 0) + return retval; Does it make sense to add a dev_err? Is that a

Re: [PATCH 4/4] staging: ste_rmi4: Suppress 'ignoring return value of ‘regulator_enable()' warning

2013-05-05 Thread Dan Carpenter
On Fri, May 03, 2013 at 12:37:14PM +0530, Srinidhi Kasagar wrote: > On Thu, May 02, 2013 at 17:48:10 +0200, Lee Jones wrote: > > drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c: > > In function ‘synaptics_rmi4_resume’: > > drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c:1090:18: > >

Re: [PATCH 4/4] staging: ste_rmi4: Suppress 'ignoring return value of ‘regulator_enable()' warning

2013-05-05 Thread Dan Carpenter
On Fri, May 03, 2013 at 12:37:14PM +0530, Srinidhi Kasagar wrote: On Thu, May 02, 2013 at 17:48:10 +0200, Lee Jones wrote: drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c: In function ‘synaptics_rmi4_resume’: drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c:1090:18: warning:

Re: [PATCH 4/4] staging: ste_rmi4: Suppress 'ignoring return value of ‘regulator_enable()' warning

2013-05-03 Thread Lee Jones
On Fri, 03 May 2013, Srinidhi Kasagar wrote: > On Thu, May 02, 2013 at 17:48:10 +0200, Lee Jones wrote: > > drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c: > > In function ‘synaptics_rmi4_resume’: > > drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c:1090:18: > > warning: ignoring

Re: [PATCH 4/4] staging: ste_rmi4: Suppress 'ignoring return value of ‘regulator_enable()' warning

2013-05-03 Thread Srinidhi Kasagar
On Thu, May 02, 2013 at 17:48:10 +0200, Lee Jones wrote: > drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c: > In function ‘synaptics_rmi4_resume’: > drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c:1090:18: > warning: ignoring return value of ‘regulator_enable’, declared > with

Re: [PATCH 4/4] staging: ste_rmi4: Suppress 'ignoring return value of ‘regulator_enable()' warning

2013-05-03 Thread Srinidhi Kasagar
On Thu, May 02, 2013 at 17:48:10 +0200, Lee Jones wrote: drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c: In function ‘synaptics_rmi4_resume’: drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c:1090:18: warning: ignoring return value of ‘regulator_enable’, declared with

Re: [PATCH 4/4] staging: ste_rmi4: Suppress 'ignoring return value of ‘regulator_enable()' warning

2013-05-03 Thread Lee Jones
On Fri, 03 May 2013, Srinidhi Kasagar wrote: On Thu, May 02, 2013 at 17:48:10 +0200, Lee Jones wrote: drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c: In function ‘synaptics_rmi4_resume’: drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c:1090:18: warning: ignoring return value

[PATCH 4/4] staging: ste_rmi4: Suppress 'ignoring return value of ‘regulator_enable()' warning

2013-05-02 Thread Lee Jones
drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c: In function ‘synaptics_rmi4_resume’: drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c:1090:18: warning: ignoring return value of ‘regulator_enable’, declared with attribute warn_unused_result [-Wunused-result Cc: Greg

[PATCH 4/4] staging: ste_rmi4: Suppress 'ignoring return value of ‘regulator_enable()' warning

2013-05-02 Thread Lee Jones
drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c: In function ‘synaptics_rmi4_resume’: drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c:1090:18: warning: ignoring return value of ‘regulator_enable’, declared with attribute warn_unused_result [-Wunused-result Cc: Greg