Re: [PATCH 4/4] x86/asm/entry/32: Use PUSH instructions to build pt_regs on stack

2015-03-27 Thread Ingo Molnar
* Denys Vlasenko wrote: > On 03/27/2015 12:32 PM, Ingo Molnar wrote: > > > > * Denys Vlasenko wrote: > > > >> This mimics the recent similar 64-bit change. > >> Saves ~110 bytes of code. > > > > Would be nice to know whether you tested all the affected system entry > > variants, on both

Re: [PATCH 4/4] x86/asm/entry/32: Use PUSH instructions to build pt_regs on stack

2015-03-27 Thread Denys Vlasenko
On 03/27/2015 12:32 PM, Ingo Molnar wrote: > > * Denys Vlasenko wrote: > >> This mimics the recent similar 64-bit change. >> Saves ~110 bytes of code. > > Would be nice to know whether you tested all the affected system entry > variants, on both AMD and Intel CPUs? Yes, I did. I also looked

Re: [PATCH 4/4] x86/asm/entry/32: Use PUSH instructions to build pt_regs on stack

2015-03-27 Thread Ingo Molnar
* Denys Vlasenko wrote: > This mimics the recent similar 64-bit change. > Saves ~110 bytes of code. Would be nice to know whether you tested all the affected system entry variants, on both AMD and Intel CPUs? that would be: > @@ -126,26 +126,27 @@ ENTRY(ia32_sysenter_target) > @@ -334,20

[PATCH 4/4] x86/asm/entry/32: Use PUSH instructions to build pt_regs on stack

2015-03-27 Thread Denys Vlasenko
This mimics the recent similar 64-bit change. Saves ~110 bytes of code. Signed-off-by: Denys Vlasenko CC: Linus Torvalds CC: Steven Rostedt CC: Ingo Molnar CC: Borislav Petkov CC: "H. Peter Anvin" CC: Andy Lutomirski CC: Oleg Nesterov CC: Frederic Weisbecker CC: Alexei Starovoitov CC:

Re: [PATCH 4/4] x86/asm/entry/32: Use PUSH instructions to build pt_regs on stack

2015-03-27 Thread Ingo Molnar
* Denys Vlasenko dvlas...@redhat.com wrote: This mimics the recent similar 64-bit change. Saves ~110 bytes of code. Would be nice to know whether you tested all the affected system entry variants, on both AMD and Intel CPUs? that would be: @@ -126,26 +126,27 @@ ENTRY(ia32_sysenter_target)

[PATCH 4/4] x86/asm/entry/32: Use PUSH instructions to build pt_regs on stack

2015-03-27 Thread Denys Vlasenko
This mimics the recent similar 64-bit change. Saves ~110 bytes of code. Signed-off-by: Denys Vlasenko dvlas...@redhat.com CC: Linus Torvalds torva...@linux-foundation.org CC: Steven Rostedt rost...@goodmis.org CC: Ingo Molnar mi...@kernel.org CC: Borislav Petkov b...@alien8.de CC: H. Peter Anvin

Re: [PATCH 4/4] x86/asm/entry/32: Use PUSH instructions to build pt_regs on stack

2015-03-27 Thread Denys Vlasenko
On 03/27/2015 12:32 PM, Ingo Molnar wrote: * Denys Vlasenko dvlas...@redhat.com wrote: This mimics the recent similar 64-bit change. Saves ~110 bytes of code. Would be nice to know whether you tested all the affected system entry variants, on both AMD and Intel CPUs? Yes, I did. I

Re: [PATCH 4/4] x86/asm/entry/32: Use PUSH instructions to build pt_regs on stack

2015-03-27 Thread Ingo Molnar
* Denys Vlasenko dvlas...@redhat.com wrote: On 03/27/2015 12:32 PM, Ingo Molnar wrote: * Denys Vlasenko dvlas...@redhat.com wrote: This mimics the recent similar 64-bit change. Saves ~110 bytes of code. Would be nice to know whether you tested all the affected system entry