Re: [PATCH 4/4] x86: entry_64.S: remove unused thread_struct::usersp

2015-03-11 Thread Denys Vlasenko
On 03/11/2015 01:55 PM, Borislav Petkov wrote: > On Tue, Mar 10, 2015 at 11:45:07AM +0100, Denys Vlasenko wrote: >> @@ -894,11 +893,6 @@ extern unsigned long thread_saved_pc(struct task_struct >> *tsk); >> #define task_pt_regs(tsk) ((struct pt_regs *)(tsk)->thread.sp0 - 1) >> extern unsigned

Re: [PATCH 4/4] x86: entry_64.S: remove unused thread_struct::usersp

2015-03-11 Thread Borislav Petkov
On Tue, Mar 10, 2015 at 11:45:07AM +0100, Denys Vlasenko wrote: > @@ -894,11 +893,6 @@ extern unsigned long thread_saved_pc(struct task_struct > *tsk); > #define task_pt_regs(tsk)((struct pt_regs *)(tsk)->thread.sp0 - 1) > extern unsigned long KSTK_ESP(struct task_struct *task); > > -/* >

Re: [PATCH 4/4] x86: entry_64.S: remove unused thread_struct::usersp

2015-03-11 Thread Denys Vlasenko
On 03/11/2015 01:55 PM, Borislav Petkov wrote: On Tue, Mar 10, 2015 at 11:45:07AM +0100, Denys Vlasenko wrote: @@ -894,11 +893,6 @@ extern unsigned long thread_saved_pc(struct task_struct *tsk); #define task_pt_regs(tsk) ((struct pt_regs *)(tsk)-thread.sp0 - 1) extern unsigned long

Re: [PATCH 4/4] x86: entry_64.S: remove unused thread_struct::usersp

2015-03-11 Thread Borislav Petkov
On Tue, Mar 10, 2015 at 11:45:07AM +0100, Denys Vlasenko wrote: @@ -894,11 +893,6 @@ extern unsigned long thread_saved_pc(struct task_struct *tsk); #define task_pt_regs(tsk)((struct pt_regs *)(tsk)-thread.sp0 - 1) extern unsigned long KSTK_ESP(struct task_struct *task); -/* - *

[PATCH 4/4] x86: entry_64.S: remove unused thread_struct::usersp

2015-03-10 Thread Denys Vlasenko
All manipulations of PER_CPU(old_rsp) in C code are removed: it is not used on SYSRET return, storing anything there is pointless. This also allows to get rid of thread_struct::usersp, which was needed only to set PER_CPU(old_rsp) for correct return from fork/clone. Tweak a few comments (we no

[PATCH 4/4] x86: entry_64.S: remove unused thread_struct::usersp

2015-03-10 Thread Denys Vlasenko
All manipulations of PER_CPU(old_rsp) in C code are removed: it is not used on SYSRET return, storing anything there is pointless. This also allows to get rid of thread_struct::usersp, which was needed only to set PER_CPU(old_rsp) for correct return from fork/clone. Tweak a few comments (we no