Re: [PATCH 4/5] PCI: iproc: Add iProc PCIe MSI support

2015-11-20 Thread Ray Jui
Hi Marc, On 11/20/2015 12:56 AM, Marc Zyngier wrote: On 19/11/15 01:37, Ray Jui wrote: Hi Marc, On 11/18/2015 12:48 AM, Marc Zyngier wrote: On Tue, 17 Nov 2015 16:31:54 -0800 Ray Jui wrote: Hi Ray, A few comments below. This patch adds PCIe MSI support for both PAXB and PAXC interfaces o

Re: [PATCH 4/5] PCI: iproc: Add iProc PCIe MSI support

2015-11-20 Thread Marc Zyngier
On 19/11/15 01:37, Ray Jui wrote: > Hi Marc, > > On 11/18/2015 12:48 AM, Marc Zyngier wrote: >> On Tue, 17 Nov 2015 16:31:54 -0800 >> Ray Jui wrote: >> >> Hi Ray, >> >> A few comments below. >> >>> This patch adds PCIe MSI support for both PAXB and PAXC interfaces on >>> all iProc based platforms

Re: [PATCH 4/5] PCI: iproc: Add iProc PCIe MSI support

2015-11-19 Thread Ray Jui
Hi Arnd, On 11/19/2015 12:31 AM, Arnd Bergmann wrote: On Wednesday 18 November 2015 17:37:16 Ray Jui wrote: I haven't spent too much time investigating, and am hoping to eventually enable affinity support with an incremental patch in the future when I have more time to investigate. Is it po

Re: [PATCH 4/5] PCI: iproc: Add iProc PCIe MSI support

2015-11-19 Thread Ray Jui
Hi Arnd, On 11/18/2015 1:50 AM, Arnd Bergmann wrote: On Wednesday 18 November 2015 08:48:45 Marc Zyngier wrote: +static inline u32 iproc_msi_read_reg(struct iproc_msi *msi, +enum iproc_msi_reg reg, +unsigned int eq) +{ +

Re: [PATCH 4/5] PCI: iproc: Add iProc PCIe MSI support

2015-11-19 Thread Arnd Bergmann
On Wednesday 18 November 2015 17:37:16 Ray Jui wrote: > >> +} > >> + > >> +static inline void iproc_msi_write_reg(struct iproc_msi *msi, > >> + enum iproc_msi_reg reg, > >> + int eq, u32 val) > >> +{ > >> +struct iproc_pcie *pc

Re: [PATCH 4/5] PCI: iproc: Add iProc PCIe MSI support

2015-11-18 Thread Ray Jui
Hi Marc, On 11/18/2015 5:37 PM, Ray Jui wrote: Hi Marc, On 11/18/2015 12:48 AM, Marc Zyngier wrote: On Tue, 17 Nov 2015 16:31:54 -0800 Ray Jui wrote: Hi Ray, A few comments below. This patch adds PCIe MSI support for both PAXB and PAXC interfaces on all iProc based platforms. The patch fo

Re: [PATCH 4/5] PCI: iproc: Add iProc PCIe MSI support

2015-11-18 Thread Ray Jui
Hi Marc, On 11/18/2015 5:37 PM, Ray Jui wrote: Hi Marc, On 11/18/2015 12:48 AM, Marc Zyngier wrote: On Tue, 17 Nov 2015 16:31:54 -0800 Ray Jui wrote: +static int iproc_msi_irq_domain_alloc(struct irq_domain *domain, + unsigned int virq, unsigned int nr_irqs, +

Re: [PATCH 4/5] PCI: iproc: Add iProc PCIe MSI support

2015-11-18 Thread Ray Jui
Hi Marc, On 11/18/2015 12:48 AM, Marc Zyngier wrote: On Tue, 17 Nov 2015 16:31:54 -0800 Ray Jui wrote: Hi Ray, A few comments below. This patch adds PCIe MSI support for both PAXB and PAXC interfaces on all iProc based platforms. The patch follows the latest trend in the kernel to use MSI d

Re: [PATCH 4/5] PCI: iproc: Add iProc PCIe MSI support

2015-11-18 Thread Arnd Bergmann
On Wednesday 18 November 2015 08:48:45 Marc Zyngier wrote: > > +static inline u32 iproc_msi_read_reg(struct iproc_msi *msi, > > +enum iproc_msi_reg reg, > > +unsigned int eq) > > +{ > > + struct iproc_pcie *pcie = msi->pcie; > > + >

Re: [PATCH 4/5] PCI: iproc: Add iProc PCIe MSI support

2015-11-18 Thread Marc Zyngier
On Tue, 17 Nov 2015 16:31:54 -0800 Ray Jui wrote: Hi Ray, A few comments below. > This patch adds PCIe MSI support for both PAXB and PAXC interfaces on > all iProc based platforms. The patch follows the latest trend in the > kernel to use MSI domain based implementation > > This iProc event qu

[PATCH 4/5] PCI: iproc: Add iProc PCIe MSI support

2015-11-17 Thread Ray Jui
This patch adds PCIe MSI support for both PAXB and PAXC interfaces on all iProc based platforms. The patch follows the latest trend in the kernel to use MSI domain based implementation This iProc event queue based MSI support should not be used with newer platforms with integrated MSI support in t