Re: [PATCH 4/5] max44000: Expose ambient sensor scaling

2016-04-10 Thread Jonathan Cameron
On 07/04/16 17:21, Crestez Dan Leonard wrote: > This patch exposes ALSTIM as illuminance_integration_time and ALSPGA as > illuminance_scale. > > Changing ALSTIM also changes the number of bits available in the data > register. Hmm.. This usually means we have oversampling going on rather than

Re: [PATCH 4/5] max44000: Expose ambient sensor scaling

2016-04-10 Thread Jonathan Cameron
On 07/04/16 17:21, Crestez Dan Leonard wrote: > This patch exposes ALSTIM as illuminance_integration_time and ALSPGA as > illuminance_scale. > > Changing ALSTIM also changes the number of bits available in the data > register. Hmm.. This usually means we have oversampling going on rather than

[PATCH 4/5] max44000: Expose ambient sensor scaling

2016-04-07 Thread Crestez Dan Leonard
This patch exposes ALSTIM as illuminance_integration_time and ALSPGA as illuminance_scale. Changing ALSTIM also changes the number of bits available in the data register. This is handled inside raw value reading because: * It's very easy to shift a few bits * It allows SCALE and INT_TIME to be

[PATCH 4/5] max44000: Expose ambient sensor scaling

2016-04-07 Thread Crestez Dan Leonard
This patch exposes ALSTIM as illuminance_integration_time and ALSPGA as illuminance_scale. Changing ALSTIM also changes the number of bits available in the data register. This is handled inside raw value reading because: * It's very easy to shift a few bits * It allows SCALE and INT_TIME to be