Re: [PATCH 4/5] net: sfc: fix return value check in efx_ptp_probe_channel().

2012-12-20 Thread Ben Hutchings
On Wed, 2012-12-12 at 00:15 -0500, David Miller wrote: > From: Cyril Roelandt > Date: Wed, 12 Dec 2012 01:24:53 +0100 > > > The ptp_clock_register() returns ERR_PTR() and never returns NULL. Replace > > the > > NULL check by a call to IS_ERR(). > > > > Signed-off-by: Cyril Roelandt > > I'll

Re: [PATCH 4/5] net: sfc: fix return value check in efx_ptp_probe_channel().

2012-12-20 Thread Ben Hutchings
On Wed, 2012-12-12 at 00:15 -0500, David Miller wrote: From: Cyril Roelandt tipec...@gmail.com Date: Wed, 12 Dec 2012 01:24:53 +0100 The ptp_clock_register() returns ERR_PTR() and never returns NULL. Replace the NULL check by a call to IS_ERR(). Signed-off-by: Cyril Roelandt

Re: [PATCH 4/5] net: sfc: fix return value check in efx_ptp_probe_channel().

2012-12-11 Thread David Miller
From: Cyril Roelandt Date: Wed, 12 Dec 2012 01:24:53 +0100 > The ptp_clock_register() returns ERR_PTR() and never returns NULL. Replace the > NULL check by a call to IS_ERR(). > > Signed-off-by: Cyril Roelandt I'll let Ben queue this up. Probably he'll want to avoid potentially leaving an

[PATCH 4/5] net: sfc: fix return value check in efx_ptp_probe_channel().

2012-12-11 Thread Cyril Roelandt
The ptp_clock_register() returns ERR_PTR() and never returns NULL. Replace the NULL check by a call to IS_ERR(). Signed-off-by: Cyril Roelandt --- drivers/net/ethernet/sfc/ptp.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/sfc/ptp.c

[PATCH 4/5] net: sfc: fix return value check in efx_ptp_probe_channel().

2012-12-11 Thread Cyril Roelandt
The ptp_clock_register() returns ERR_PTR() and never returns NULL. Replace the NULL check by a call to IS_ERR(). Signed-off-by: Cyril Roelandt tipec...@gmail.com --- drivers/net/ethernet/sfc/ptp.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 4/5] net: sfc: fix return value check in efx_ptp_probe_channel().

2012-12-11 Thread David Miller
From: Cyril Roelandt tipec...@gmail.com Date: Wed, 12 Dec 2012 01:24:53 +0100 The ptp_clock_register() returns ERR_PTR() and never returns NULL. Replace the NULL check by a call to IS_ERR(). Signed-off-by: Cyril Roelandt tipec...@gmail.com I'll let Ben queue this up. Probably he'll want to