Re: [PATCH 4/5] perf intel-pt: Insert callchain context into synthesized callchains

2018-10-31 Thread Arnaldo Carvalho de Melo
f (context != last_context) { > > > > Shall I send V2? > > I have attached it Thanks! > >From 19a9fbdbd3729c7f14c9c1f0ac79c18cce91ff60 Mon Sep 17 00:00:00 2001 > From: Adrian Hunter > Date: Wed, 31 Oct 2018 09:31:25 +0200 > Subject: [PATCH V2 4/5] perf

Re: [PATCH 4/5] perf intel-pt: Insert callchain context into synthesized callchains

2018-10-31 Thread Arnaldo Carvalho de Melo
f (context != last_context) { > > > > Shall I send V2? > > I have attached it Thanks! > >From 19a9fbdbd3729c7f14c9c1f0ac79c18cce91ff60 Mon Sep 17 00:00:00 2001 > From: Adrian Hunter > Date: Wed, 31 Oct 2018 09:31:25 +0200 > Subject: [PATCH V2 4/5] perf

Re: [PATCH 4/5] perf intel-pt: Insert callchain context into synthesized callchains

2018-10-31 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 31, 2018 at 04:15:26PM +0200, Adrian Hunter escreveu: > On 31/10/18 3:28 PM, Arnaldo Carvalho de Melo wrote: > > Em Wed, Oct 31, 2018 at 11:10:42AM +0200, Adrian Hunter escreveu: > >> In the absence of a fallback, callchains must encode also the callchain > >> context. Do that now

Re: [PATCH 4/5] perf intel-pt: Insert callchain context into synthesized callchains

2018-10-31 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 31, 2018 at 04:15:26PM +0200, Adrian Hunter escreveu: > On 31/10/18 3:28 PM, Arnaldo Carvalho de Melo wrote: > > Em Wed, Oct 31, 2018 at 11:10:42AM +0200, Adrian Hunter escreveu: > >> In the absence of a fallback, callchains must encode also the callchain > >> context. Do that now

Re: [PATCH 4/5] perf intel-pt: Insert callchain context into synthesized callchains

2018-10-31 Thread Adrian Hunter
hread->ts->cnt - j].ret_addr; > context = callchain_context(ip, kernel_start); > if (context != last_context) { > > Shall I send V2? I have attached it >From 19a9fbdbd3729c7f14c9c1f0ac79c18cce91ff60 Mon Sep 17 00:00:00 2001 From: Adrian Hunter Dat

Re: [PATCH 4/5] perf intel-pt: Insert callchain context into synthesized callchains

2018-10-31 Thread Adrian Hunter
hread->ts->cnt - j].ret_addr; > context = callchain_context(ip, kernel_start); > if (context != last_context) { > > Shall I send V2? I have attached it >From 19a9fbdbd3729c7f14c9c1f0ac79c18cce91ff60 Mon Sep 17 00:00:00 2001 From: Adrian Hunter Dat

Re: [PATCH 4/5] perf intel-pt: Insert callchain context into synthesized callchains

2018-10-31 Thread Adrian Hunter
On 31/10/18 3:28 PM, Arnaldo Carvalho de Melo wrote: > Em Wed, Oct 31, 2018 at 11:10:42AM +0200, Adrian Hunter escreveu: >> In the absence of a fallback, callchains must encode also the callchain >> context. Do that now there is no fallback. > > So, this one is independent of the first 3 patches,

Re: [PATCH 4/5] perf intel-pt: Insert callchain context into synthesized callchains

2018-10-31 Thread Adrian Hunter
On 31/10/18 3:28 PM, Arnaldo Carvalho de Melo wrote: > Em Wed, Oct 31, 2018 at 11:10:42AM +0200, Adrian Hunter escreveu: >> In the absence of a fallback, callchains must encode also the callchain >> context. Do that now there is no fallback. > > So, this one is independent of the first 3 patches,

Re: [PATCH 4/5] perf intel-pt: Insert callchain context into synthesized callchains

2018-10-31 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 31, 2018 at 11:10:42AM +0200, Adrian Hunter escreveu: > In the absence of a fallback, callchains must encode also the callchain > context. Do that now there is no fallback. So, this one is independent of the first 3 patches, right? Ok, applying it first, I'll relook the first ones

Re: [PATCH 4/5] perf intel-pt: Insert callchain context into synthesized callchains

2018-10-31 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 31, 2018 at 11:10:42AM +0200, Adrian Hunter escreveu: > In the absence of a fallback, callchains must encode also the callchain > context. Do that now there is no fallback. So, this one is independent of the first 3 patches, right? Ok, applying it first, I'll relook the first ones

[PATCH 4/5] perf intel-pt: Insert callchain context into synthesized callchains

2018-10-31 Thread Adrian Hunter
In the absence of a fallback, callchains must encode also the callchain context. Do that now there is no fallback. Signed-off-by: Adrian Hunter Cc: sta...@vger.kernel.org # 4.19 --- tools/perf/util/intel-pt.c | 6 +++-- tools/perf/util/thread-stack.c | 44 +++---

[PATCH 4/5] perf intel-pt: Insert callchain context into synthesized callchains

2018-10-31 Thread Adrian Hunter
In the absence of a fallback, callchains must encode also the callchain context. Do that now there is no fallback. Signed-off-by: Adrian Hunter Cc: sta...@vger.kernel.org # 4.19 --- tools/perf/util/intel-pt.c | 6 +++-- tools/perf/util/thread-stack.c | 44 +++---