Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.

Signed-off-by: Krzysztof Kozlowski <k...@kernel.org>
---
 drivers/power/supply/ingenic-battery.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/power/supply/ingenic-battery.c 
b/drivers/power/supply/ingenic-battery.c
index dd3d93dfe3eb..32dc77fd9a95 100644
--- a/drivers/power/supply/ingenic-battery.c
+++ b/drivers/power/supply/ingenic-battery.c
@@ -147,11 +147,9 @@ static int ingenic_battery_probe(struct platform_device 
*pdev)
        psy_cfg.of_node = dev->of_node;
 
        bat->battery = devm_power_supply_register(dev, desc, &psy_cfg);
-       if (IS_ERR(bat->battery)) {
-               if (PTR_ERR(bat->battery) != -EPROBE_DEFER)
-                       dev_err(dev, "Unable to register battery\n");
-               return PTR_ERR(bat->battery);
-       }
+       if (IS_ERR(bat->battery))
+               return dev_err_probe(dev, PTR_ERR(bat->battery),
+                                    "Unable to register battery\n");
 
        ret = power_supply_get_battery_info(bat->battery, &bat->info);
        if (ret) {
-- 
2.17.1

Reply via email to