Re: [PATCH 4/5] regulator: core: Add early supply resolution for a bypassed regulator

2016-04-25 Thread Mark Brown
On Mon, Apr 25, 2016 at 03:44:24PM +0100, Jon Hunter wrote: > On 22/04/16 14:53, Mark Brown wrote: > > We need to only *fail* in the bypass case. > OK. So this is what I have now. Is it weird to return EPROBE_DEFER in > _regulator_get_voltage()? If so, I could add a test for bypass in the >

Re: [PATCH 4/5] regulator: core: Add early supply resolution for a bypassed regulator

2016-04-25 Thread Mark Brown
On Mon, Apr 25, 2016 at 03:44:24PM +0100, Jon Hunter wrote: > On 22/04/16 14:53, Mark Brown wrote: > > We need to only *fail* in the bypass case. > OK. So this is what I have now. Is it weird to return EPROBE_DEFER in > _regulator_get_voltage()? If so, I could add a test for bypass in the >

Re: [PATCH 4/5] regulator: core: Add early supply resolution for a bypassed regulator

2016-04-25 Thread Jon Hunter
On 22/04/16 14:53, Mark Brown wrote: > * PGP Signed by an unknown key > > On Fri, Apr 22, 2016 at 12:26:57PM +0100, Jon Hunter wrote: > >> OK. Sorry if I have misunderstood you here, but this sounds more like >> Thierry's initial proposal [0] but ignoring the any errors returned (and >> we need

Re: [PATCH 4/5] regulator: core: Add early supply resolution for a bypassed regulator

2016-04-25 Thread Jon Hunter
On 22/04/16 14:53, Mark Brown wrote: > * PGP Signed by an unknown key > > On Fri, Apr 22, 2016 at 12:26:57PM +0100, Jon Hunter wrote: > >> OK. Sorry if I have misunderstood you here, but this sounds more like >> Thierry's initial proposal [0] but ignoring the any errors returned (and >> we need

Re: [PATCH 4/5] regulator: core: Add early supply resolution for a bypassed regulator

2016-04-22 Thread Mark Brown
On Fri, Apr 22, 2016 at 12:26:57PM +0100, Jon Hunter wrote: > OK. Sorry if I have misunderstood you here, but this sounds more like > Thierry's initial proposal [0] but ignoring the any errors returned (and > we need to fix-up the locking in this patch). In the discussion that Yes! > followed I

Re: [PATCH 4/5] regulator: core: Add early supply resolution for a bypassed regulator

2016-04-22 Thread Mark Brown
On Fri, Apr 22, 2016 at 12:26:57PM +0100, Jon Hunter wrote: > OK. Sorry if I have misunderstood you here, but this sounds more like > Thierry's initial proposal [0] but ignoring the any errors returned (and > we need to fix-up the locking in this patch). In the discussion that Yes! > followed I

Re: [PATCH 4/5] regulator: core: Add early supply resolution for a bypassed regulator

2016-04-22 Thread Jon Hunter
On 22/04/16 11:48, Mark Brown wrote: > * PGP Signed by an unknown key > > On Thu, Apr 21, 2016 at 05:12:00PM +0100, Jon Hunter wrote: > >> A regulator that is in bypass will fail to be registered because we will >> attempt to get the voltage of the regulator (ie. it's bypass voltage) >> before

Re: [PATCH 4/5] regulator: core: Add early supply resolution for a bypassed regulator

2016-04-22 Thread Jon Hunter
On 22/04/16 11:48, Mark Brown wrote: > * PGP Signed by an unknown key > > On Thu, Apr 21, 2016 at 05:12:00PM +0100, Jon Hunter wrote: > >> A regulator that is in bypass will fail to be registered because we will >> attempt to get the voltage of the regulator (ie. it's bypass voltage) >> before

Re: [PATCH 4/5] regulator: core: Add early supply resolution for a bypassed regulator

2016-04-22 Thread Mark Brown
On Thu, Apr 21, 2016 at 05:12:00PM +0100, Jon Hunter wrote: > A regulator that is in bypass will fail to be registered because we will > attempt to get the voltage of the regulator (ie. it's bypass voltage) > before the supply for the regulator has been resolved. Therefore, when > getting the

Re: [PATCH 4/5] regulator: core: Add early supply resolution for a bypassed regulator

2016-04-22 Thread Mark Brown
On Thu, Apr 21, 2016 at 05:12:00PM +0100, Jon Hunter wrote: > A regulator that is in bypass will fail to be registered because we will > attempt to get the voltage of the regulator (ie. it's bypass voltage) > before the supply for the regulator has been resolved. Therefore, when > getting the

[PATCH 4/5] regulator: core: Add early supply resolution for a bypassed regulator

2016-04-21 Thread Jon Hunter
The call to set_machine_constraints() in regulator_register(), will attempt to get the voltage for the regulator. A regulator that is in bypass will fail to be registered because we will attempt to get the voltage of the regulator (ie. it's bypass voltage) before the supply for the regulator has

[PATCH 4/5] regulator: core: Add early supply resolution for a bypassed regulator

2016-04-21 Thread Jon Hunter
The call to set_machine_constraints() in regulator_register(), will attempt to get the voltage for the regulator. A regulator that is in bypass will fail to be registered because we will attempt to get the voltage of the regulator (ie. it's bypass voltage) before the supply for the regulator has