Re: [PATCH 4/5] regulator: core: simplify _regulator_get()

2017-02-05 Thread Mark Brown
On Sat, Feb 04, 2017 at 10:27:33AM -0800, Dmitry Torokhov wrote: > Do you need me to put this into commit description or this is > sufficient? Yes, please make a commit log version - I suspect someone is going to need it in future when trying to follow the code. signature.asc Description: PGP

Re: [PATCH 4/5] regulator: core: simplify _regulator_get()

2017-02-05 Thread Mark Brown
On Sat, Feb 04, 2017 at 10:27:33AM -0800, Dmitry Torokhov wrote: > Do you need me to put this into commit description or this is > sufficient? Yes, please make a commit log version - I suspect someone is going to need it in future when trying to follow the code. signature.asc Description: PGP

Re: [PATCH 4/5] regulator: core: simplify _regulator_get()

2017-02-04 Thread Dmitry Torokhov
On Sat, Feb 04, 2017 at 11:34:58AM +0100, Mark Brown wrote: > On Fri, Feb 03, 2017 at 01:56:03PM -0800, Dmitry Torokhov wrote: > > The code in _regulator_get() got a bit confusing over time, with control > > flow jumping to a label from couple of places. Let's untangle it a bit. > > This is quite

Re: [PATCH 4/5] regulator: core: simplify _regulator_get()

2017-02-04 Thread Dmitry Torokhov
On Sat, Feb 04, 2017 at 11:34:58AM +0100, Mark Brown wrote: > On Fri, Feb 03, 2017 at 01:56:03PM -0800, Dmitry Torokhov wrote: > > The code in _regulator_get() got a bit confusing over time, with control > > flow jumping to a label from couple of places. Let's untangle it a bit. > > This is quite

Re: [PATCH 4/5] regulator: core: simplify _regulator_get()

2017-02-04 Thread Mark Brown
On Fri, Feb 03, 2017 at 01:56:03PM -0800, Dmitry Torokhov wrote: > The code in _regulator_get() got a bit confusing over time, with control > flow jumping to a label from couple of places. Let's untangle it a bit. This is quite hard to review without a concrete description of what the changes

Re: [PATCH 4/5] regulator: core: simplify _regulator_get()

2017-02-04 Thread Mark Brown
On Fri, Feb 03, 2017 at 01:56:03PM -0800, Dmitry Torokhov wrote: > The code in _regulator_get() got a bit confusing over time, with control > flow jumping to a label from couple of places. Let's untangle it a bit. This is quite hard to review without a concrete description of what the changes

[PATCH 4/5] regulator: core: simplify _regulator_get()

2017-02-03 Thread Dmitry Torokhov
The code in _regulator_get() got a bit confusing over time, with control flow jumping to a label from couple of places. Let's untangle it a bit. Signed-off-by: Dmitry Torokhov --- drivers/regulator/core.c | 66 +--- 1 file

[PATCH 4/5] regulator: core: simplify _regulator_get()

2017-02-03 Thread Dmitry Torokhov
The code in _regulator_get() got a bit confusing over time, with control flow jumping to a label from couple of places. Let's untangle it a bit. Signed-off-by: Dmitry Torokhov --- drivers/regulator/core.c | 66 +--- 1 file changed, 34 insertions(+),