Re: [PATCH 4/6] extcon: arizona: Add device binding for second jack detect pin on GPIO5

On Fri, Sep 25, 2015 at 6:10 PM, Charles Keepax wrote: > On Fri, Sep 25, 2015 at 09:54:26AM +0900, Chanwoo Choi wrote: >> Hi Charles, >> >> I have one comment. >> I think current extcon-arizona.c has the many platform data >> so, extcon-arizona.c use the too much if statement to support each

Re: [PATCH 4/6] extcon: arizona: Add device binding for second jack detect pin on GPIO5

On Fri, Sep 25, 2015 at 6:10 PM, Charles Keepax wrote: > On Fri, Sep 25, 2015 at 09:54:26AM +0900, Chanwoo Choi wrote: >> Hi Charles, >> >> I have one comment. >> I think current extcon-arizona.c has the many platform data >> so, extcon-arizona.c use the too

Re: [PATCH 4/6] extcon: arizona: Add device binding for second jack detect pin on GPIO5

On Fri, Sep 25, 2015 at 09:54:26AM +0900, Chanwoo Choi wrote: > Hi Charles, > > I have one comment. > I think current extcon-arizona.c has the many platform data > so, extcon-arizona.c use the too much if statement to support each feature > for different wolfsonmicro codec. I think it cause the

Re: [PATCH 4/6] extcon: arizona: Add device binding for second jack detect pin on GPIO5

On Fri, Sep 25, 2015 at 09:54:26AM +0900, Chanwoo Choi wrote: > Hi Charles, > > I have one comment. > I think current extcon-arizona.c has the many platform data > so, extcon-arizona.c use the too much if statement to support each feature > for different wolfsonmicro codec. I think it cause the

Re: [PATCH 4/6] extcon: arizona: Add device binding for second jack detect pin on GPIO5

Hi Charles, I have one comment. I think current extcon-arizona.c has the many platform data so, extcon-arizona.c use the too much if statement to support each feature for different wolfsonmicro codec. I think it cause the complicated code. For example, You may use 'struct of_device_id' as

Re: [PATCH 4/6] extcon: arizona: Add device binding for second jack detect pin on GPIO5

Hi Charles, I have one comment. I think current extcon-arizona.c has the many platform data so, extcon-arizona.c use the too much if statement to support each feature for different wolfsonmicro codec. I think it cause the complicated code. For example, You may use 'struct of_device_id' as

[PATCH 4/6] extcon: arizona: Add device binding for second jack detect pin on GPIO5

Some Arizona devices have the option to use the GPIO5 pin as a second jack detection pin. This patch adds device bindings to specify to the driver that it should use this pin. Note that the second jack detection pin is hard wired in the chip so can only be enabled through the binding, rather than

[PATCH 4/6] extcon: arizona: Add device binding for second jack detect pin on GPIO5

Some Arizona devices have the option to use the GPIO5 pin as a second jack detection pin. This patch adds device bindings to specify to the driver that it should use this pin. Note that the second jack detection pin is hard wired in the chip so can only be enabled through the binding, rather than