Re: [PATCH 4/6] mm, compaction: always skip compound pages by order in migrate scanner

2015-06-19 Thread Mel Gorman
On Wed, Jun 10, 2015 at 11:32:32AM +0200, Vlastimil Babka wrote: > The compaction migrate scanner tries to skip compound pages by their order, to > reduce number of iterations for pages it cannot isolate. The check is only > done > if PageLRU() is true, which means it applies to THP pages, but

Re: [PATCH 4/6] mm, compaction: always skip compound pages by order in migrate scanner

2015-06-19 Thread Mel Gorman
On Wed, Jun 10, 2015 at 11:32:32AM +0200, Vlastimil Babka wrote: The compaction migrate scanner tries to skip compound pages by their order, to reduce number of iterations for pages it cannot isolate. The check is only done if PageLRU() is true, which means it applies to THP pages, but not

Re: [PATCH 4/6] mm, compaction: always skip compound pages by order in migrate scanner

2015-06-16 Thread Vlastimil Babka
On 06/16/2015 07:44 AM, Joonsoo Kim wrote: > On Wed, Jun 10, 2015 at 11:32:32AM +0200, Vlastimil Babka wrote: [...] >> @@ -723,39 +725,35 @@ isolate_migratepages_block(struct compact_control *cc, >> unsigned long low_pfn, >> * It's possible to migrate LRU pages and balloon pages

Re: [PATCH 4/6] mm, compaction: always skip compound pages by order in migrate scanner

2015-06-16 Thread Vlastimil Babka
On 06/16/2015 07:44 AM, Joonsoo Kim wrote: On Wed, Jun 10, 2015 at 11:32:32AM +0200, Vlastimil Babka wrote: [...] @@ -723,39 +725,35 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn, * It's possible to migrate LRU pages and balloon pages

Re: [PATCH 4/6] mm, compaction: always skip compound pages by order in migrate scanner

2015-06-15 Thread Joonsoo Kim
On Wed, Jun 10, 2015 at 11:32:32AM +0200, Vlastimil Babka wrote: > The compaction migrate scanner tries to skip compound pages by their order, to > reduce number of iterations for pages it cannot isolate. The check is only > done > if PageLRU() is true, which means it applies to THP pages, but

Re: [PATCH 4/6] mm, compaction: always skip compound pages by order in migrate scanner

2015-06-15 Thread Joonsoo Kim
On Wed, Jun 10, 2015 at 11:32:32AM +0200, Vlastimil Babka wrote: The compaction migrate scanner tries to skip compound pages by their order, to reduce number of iterations for pages it cannot isolate. The check is only done if PageLRU() is true, which means it applies to THP pages, but not

Re: [PATCH 4/6] mm, compaction: always skip compound pages by order in migrate scanner

2015-06-12 Thread Michal Nazarewicz
On Wed, Jun 10 2015, Vlastimil Babka wrote: > The compaction migrate scanner tries to skip compound pages by their order, to > reduce number of iterations for pages it cannot isolate. The check is only > done > if PageLRU() is true, which means it applies to THP pages, but not e.g. > hugetlbfs

Re: [PATCH 4/6] mm, compaction: always skip compound pages by order in migrate scanner

2015-06-12 Thread Michal Nazarewicz
On Wed, Jun 10 2015, Vlastimil Babka wrote: The compaction migrate scanner tries to skip compound pages by their order, to reduce number of iterations for pages it cannot isolate. The check is only done if PageLRU() is true, which means it applies to THP pages, but not e.g. hugetlbfs pages

[PATCH 4/6] mm, compaction: always skip compound pages by order in migrate scanner

2015-06-10 Thread Vlastimil Babka
The compaction migrate scanner tries to skip compound pages by their order, to reduce number of iterations for pages it cannot isolate. The check is only done if PageLRU() is true, which means it applies to THP pages, but not e.g. hugetlbfs pages or any other non-LRU compound pages, which we have

[PATCH 4/6] mm, compaction: always skip compound pages by order in migrate scanner

2015-06-10 Thread Vlastimil Babka
The compaction migrate scanner tries to skip compound pages by their order, to reduce number of iterations for pages it cannot isolate. The check is only done if PageLRU() is true, which means it applies to THP pages, but not e.g. hugetlbfs pages or any other non-LRU compound pages, which we have