Re: [PATCH 4/6] staging: comedi: addi_apci_1564: simplify the PCI bar reading and don't read the unused bars

2014-04-29 Thread Chase Southwood
Hartley and Ian, Yes, I had a feeling I should have gone with what was present, but my desire to follow the documentation I wasn't too familiar with won out :P I'll spin a new revision of this patchset ASAP with this changed back and all of my bad titles (oof...) fixed as well and I'll make sure

Re: [PATCH 4/6] staging: comedi: addi_apci_1564: simplify the PCI bar reading and don't read the unused bars

2014-04-29 Thread Chase Southwood
Hartley and Ian, Yes, I had a feeling I should have gone with what was present, but my desire to follow the documentation I wasn't too familiar with won out :P I'll spin a new revision of this patchset ASAP with this changed back and all of my bad titles (oof...) fixed as well and I'll make sure

Re: [PATCH 4/6] staging: comedi: addi_apci_1564: simplify the PCI bar reading and don't read the unused bars

2014-04-28 Thread Ian Abbott
On 2014-04-28 11:19, Ian Abbott wrote: On 2014-04-27 02:37, Chase Southwood wrote: This driver only uses PCI bar 1 (devpriv->i_IobaseAmcc), and PCI bar 2 (dev->iobase) doon't bother reading the unused PCI bars. Signed-off-by: Chase Southwood Cc: Ian Abbott Cc: H Hartley Sweeten ---

Re: [PATCH 4/6] staging: comedi: addi_apci_1564: simplify the PCI bar reading and don't read the unused bars

2014-04-28 Thread Ian Abbott
On 2014-04-27 02:37, Chase Southwood wrote: This driver only uses PCI bar 1 (devpriv->i_IobaseAmcc), and PCI bar 2 (dev->iobase) doon't bother reading the unused PCI bars. Signed-off-by: Chase Southwood Cc: Ian Abbott Cc: H Hartley Sweeten --- Hartley, As far as I can tell from reading the

Re: [PATCH 4/6] staging: comedi: addi_apci_1564: simplify the PCI bar reading and don't read the unused bars

2014-04-28 Thread Ian Abbott
On 2014-04-27 02:37, Chase Southwood wrote: This driver only uses PCI bar 1 (devpriv-i_IobaseAmcc), and PCI bar 2 (dev-iobase) doon't bother reading the unused PCI bars. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley Sweeten

Re: [PATCH 4/6] staging: comedi: addi_apci_1564: simplify the PCI bar reading and don't read the unused bars

2014-04-28 Thread Ian Abbott
On 2014-04-28 11:19, Ian Abbott wrote: On 2014-04-27 02:37, Chase Southwood wrote: This driver only uses PCI bar 1 (devpriv-i_IobaseAmcc), and PCI bar 2 (dev-iobase) doon't bother reading the unused PCI bars. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott

[PATCH 4/6] staging: comedi: addi_apci_1564: simplify the PCI bar reading and don't read the unused bars

2014-04-26 Thread Chase Southwood
This driver only uses PCI bar 1 (devpriv->i_IobaseAmcc), and PCI bar 2 (dev->iobase) doon't bother reading the unused PCI bars. Signed-off-by: Chase Southwood Cc: Ian Abbott Cc: H Hartley Sweeten --- Hartley, As far as I can tell from reading the I/O Mapping you sent me, these bar numbers

[PATCH 4/6] staging: comedi: addi_apci_1564: simplify the PCI bar reading and don't read the unused bars

2014-04-26 Thread Chase Southwood
This driver only uses PCI bar 1 (devpriv-i_IobaseAmcc), and PCI bar 2 (dev-iobase) doon't bother reading the unused PCI bars. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley Sweeten hswee...@visionengravers.com --- Hartley, As far as I can